633492 - remove useless test-window-helpers.js dump statements

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Attachment: remove dump statements

I left a bunch of annoying dump statements in test-window-helpers.js.  They may have been useful at some point, but they just seem to add useless gibberish to the output at this point.

Comment 1

[Rain [:rain1] (inactive)]

Comment on attachment 511708 [details] [diff] [review]
remove dump statements

> 
>       try {
>-        dump("::: calling\n");
>         try {
>           let runner = new frame.Runner(collector);
>           runner.wrapper(this.subTestFunc, troller);
>         }
>         catch (ex) {
>-          dump("problem running: " + ex.fileName + ":" + ex.lineNumber + ": " + ex + "\n");
>         }

I think this should result in a failure, so please remove the try/catch as well.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

(In reply to comment #1)
> I think this should result in a failure, so please remove the try/catch as
> well.

It appears the wrapper function takes care of all of the exception handling for us anyways, so that code was moot.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

pushed to trunk with requested changed:
http://hg.mozilla.org/comm-central/rev/625f6f4e11bd