Double windows and messed up UI on WinXp with Firebug 1.7a10 on FF4.0b

RESOLVED INCOMPLETE

Status

()

Firefox
General
RESOLVED INCOMPLETE
7 years ago
7 years ago

People

(Reporter: John J. Barton, Unassigned)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
1. Use WinXP
2.  Install Firebug 1.7a10
http://getfirebug.com/releases/firebug/1.7X/firebug-1.7X.0a10.xpi
3. Open Firebug.

I don't have WinXp so I've not tried this myself, but we have lots of reports

Issue 4012: 	Minefield's UI problem using firebug head svn
http://code.google.com/p/fbug/issues/detail?id=4012
http://groups.google.com/group/firebug/browse_thread/thread/cf02cb3e27e04954

It's possible we can workaround it on Firebug source, if we knew what caused it.
(Reporter)

Updated

7 years ago
blocking2.0: --- → ?
Whiteboard: [firebug-p1]
Confirmed using Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110211 Firefox/4.0b12pre ID:20110211030400
Keywords: regressionwindow-wanted
Ah well, this is not a Regression since the Issue happens on older Builds with Firebug 1.7a10 applied to, too.
Keywords: regressionwindow-wanted
The problem is with setToolbarVisibility (defined in browser.js)

Firebug is using it for auto opening the add-on bar as follows:

var addonBar = document.getElementById("addon-bar");
setToolbarVisibility(addonBar, true);

If I remove it from the code the problem is gone.

It's easy for Firebug to work around, but I would like to yet explore why this actually happens.

Honza
Forgot to add, this is not hardblocker since as I mentioned Firebug can work around.
Honza
(Reporter)

Comment 5

7 years ago
I removed the blocking request that I added.
blocking2.0: ? → ---
Whiteboard: [firebug-p1]

Comment 6

7 years ago
This may not need blocking, but I would request blocklisting this. This completely breaks the browser (Safe mode is required to even get to any URL, including about:addons, even from the menu). 

This is what was done for Stylish 1.1b when all it did was break the update manager. Plus, Firebug 1.7a9 is unaffected, and, as stated, the fix for the next version seems pretty easy.

If it matters, I can also confirm this bug in Firefox 4.0b11 (as you would expect with it existing in Firefox 4.0b12pre).
Duplicate of this bug: 633962
Duplicate of this bug: 633998
Duplicate of this bug: 633655

Updated

7 years ago
Duplicate of this bug: 634092
(In reply to comment #3)
> The problem is with setToolbarVisibility (defined in browser.js)
> 
> Firebug is using it for auto opening the add-on bar as follows:
> 
> var addonBar = document.getElementById("addon-bar");
> setToolbarVisibility(addonBar, true);

This alone doesn't seem to trigger this bug, so there must be going on something else on the firebug side.
(Reporter)

Comment 12

7 years ago
Here is the patch where we removed our use of setToolbarVisibility.

http://code.google.com/p/fbug/source/detail?r=9362

Firebug 1.7a10 file knownIssues.js uses the function, 1.7a9 does not.
http://getfirebug.com/releases/firebug/1.7X/

The diff from this page might also help:
http://code.google.com/p/fbug/source/browse/branches/firebug1.7/content/firebug/knownIssues.js
Maybe you were calling setToolbarVisibility too early when the window wasn't ready for one of the subsequent calls, e.g. updateAppButtonDisplay? I can only guess.

A diff showing setToolbarVisibility being replaced doesn't really help, since the problem still doesn't occur in stock Firefox. So right now the steps to reproduce remain "install Firebug 1.7a10", which isn't narrow enough.
(Reporter)

Comment 14

7 years ago
In comment 12 we have it narrowed down to two lines, very reproducible, only WinXP.
I called setToolbarVisibility(document.getElementById("addon-bar"), true) on XP. It didn't cause this bug, as mentioned in comment 11.

Updated

7 years ago
Duplicate of this bug: 634208

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INCOMPLETE

Comment 17

7 years ago
WFM with firebug 1.7X.0a11.
Note that, Firebug 1.7a11 fixed the problem by not using the setToolbarVisibility.
Honza
Component: XUL → General
Product: Core → Firefox
QA Contact: xptoolkit.widgets → general

Comment 19

7 years ago
I ran into this problem again when I tried out Favicon Picker 2 0.6.14. If it is doing something different, it might help track down this bug.
You need to log in before you can comment on or make changes to this bug.