The default bug view has changed. See this FAQ.

deCOM nsIHTMLEditRules

RESOLVED FIXED in mozilla6

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: Sebastian Kromp)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla6
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

nsIHTMLEditRules is completely internal to editor/libeditor/html and the concrete type is always known.

Updated

6 years ago
Assignee: nobody → ehsan
Whiteboard: [post-2.0]

Updated

6 years ago
OS: Windows 7 → All
Hardware: x86 → All
(Assignee)

Updated

6 years ago
Assignee: ehsan → 46b
(Assignee)

Comment 1

6 years ago
Created attachment 525061 [details] [diff] [review]
Removed nsIHTMLEditRules and made the methods member of nsHTMLEditRules

This is my first patch with use of the queue, so I hope all went fine. I´m not sure about the "former nsIHTMLEditRules methods" comments, but I thought it could be useful.
Attachment #525061 - Flags: review?(khuey)
Attachment #525061 - Flags: review?(khuey) → review?(ehsan)
Comment on attachment 525061 [details] [diff] [review]
Removed nsIHTMLEditRules and made the methods member of nsHTMLEditRules

Please remove the "former nsIHTMLEditRules methods" comment.

But more importantly, you should remove all of the nsIHTMLEditRules uses from the tree.  I don't think that this patch even compiles.  Here is a full list of these uses: <http://mxr.mozilla.org/mozilla-central/ident?i=nsIHTMLEditRules>
Attachment #525061 - Flags: review?(ehsan) → review-
Specifically, you should just use static_cast to cast the mRules pointer to the nsHTMLEditRules concrete type instead of the query interface call.
(Assignee)

Comment 4

6 years ago
Created attachment 527927 [details] [diff] [review]
Removed nsIHTMLEditRules and made the methods member of nsHTMLEditRules

If I hadn´t messed up with the queue again, it should work fine now. I had took a look over it and couldn´t see something missing now.
I hope I´m right. :)
Attachment #525061 - Attachment is obsolete: true
Attachment #527927 - Flags: review?(ehsan)
Comment on attachment 527927 [details] [diff] [review]
Removed nsIHTMLEditRules and made the methods member of nsHTMLEditRules

Review of attachment 527927 [details] [diff] [review]:

This looks really good, thanks!

Have you also tested this on the try server?  If yes, it can land I think.
Attachment #527927 - Flags: review?(ehsan) → review+
(Assignee)

Comment 6

6 years ago
No I had now tried to, but it doesn´t worked. I have found this guide here https://wiki.mozilla.org/ReleaseEngineering/TryServer, but I´ve got everytime a error message from Putty: "No supported authentication methods available"
The last command at this site (with the -e ...) isn´t even recognized as valid command at all. I´m using TortoiseHG, maybe this is the problem? (And is it okay to ask here? Else I will ask per e-mail next time)

Anyway, thank you :)
I've never used putty with tortoisehg myself (I use the hg command from the terminal!), but looking at http://row1.info/news/91-blog/265-using-tortoisehg-with-bitbucket-and-ssh.html, it seems that you need a line like this in your mercurial.ini file:

ssh = "C:\Program Files (x86)\TortoiseHg\TortoisePlink.exe" -ssh -2 -i C:\Users\YourUsername\.ssh\yourkey.ppk

Also, make sure that your LDAP user name in the URL.

If that doesn't work out, you can always use the command line.  In order to do that, you should export your SSH key from putty into the OpenSSH format, put it in ~/.ssh/.id_rsa (private key) and ~/.ssh/.id_rsa.pub (public key), and modify ~/.ssh/config like this: <https://developer.mozilla.org/en/Creating_Mercurial_User_Repositories#Configuring_ssh>, and push to try using hg push -f ssh://hg.mozilla.org/try.  That configuration is guaranteed to work.  :-)

Let me know if you can't get it to work.
(Assignee)

Comment 8

6 years ago
Okay, I`ve now got the testresults:
http://tbpl.mozilla.org/?tree=Try&rev=5eb262e4e6e3
There are some warnings and errors, but I´m not sure if they have something to do with my changes.

Comment 9

6 years ago
The non-android reftests are a known intermittent orange. Jetpack failures are expected, I believe. Android browser-chrome failures are expected. Android Mochitest 2 looks like an infra or harness failure. Android R2 looks like the same. The mobile folks tell me that the failing Android R1 tests are nothing to worry about either. I think you're clear!
Indeed!  Thanks for your patch!  :-)
Keywords: checkin-needed
Whiteboard: [post-2.0]
Thanks for the patch Sebastian. It's now pushed to the cedar repository which will be merged to mozilla-central soon.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Version: unspecified → Trunk
(Assignee)

Comment 12

6 years ago
Thank you very much! I´m glad that I could help. :)
It's now in mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/33d37164fd18
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6

Updated

6 years ago
Keywords: dev-doc-needed
Noted the removal of this interface.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.