Closed
Bug 634088
Opened 14 years ago
Closed 14 years ago
Use native rendering for indeterminate progress bar (Cocoa)
Categories
(Core :: Widget: Cocoa, defect)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file, 2 obsolete files)
|
4.30 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
The widget is ready for that but it would required looking at the content states. Should be easy.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #512730 -
Flags: review?(mstange)
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review]
|
||
Comment 2•14 years ago
|
||
Comment on attachment 512730 [details] [diff] [review]
Patch v1
Looks good, but please request another review from roc because I'm not a peer for the xpwidgets code.
One thing: I'm not sure whether you should bother with the content null check since we mostly skip it in the rest of the file. The only cases when I've seen frames with null content was during frame destruction and when the frame is an nsViewportFrame, and none of those cases can be hit in native theme drawing as far as I know.
Attachment #512730 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
r=mstange
Attachment #512730 -
Attachment is obsolete: true
Attachment #512748 -
Flags: review?(roc)
|
|
Assignee | |
Comment 4•14 years ago
|
||
I realized I should use nsWidgetAtoms intsead of nsGkAtoms.
Attachment #512748 -
Attachment is obsolete: true
Attachment #513140 -
Flags: review?(roc)
Attachment #512748 -
Flags: review?(roc)
Attachment #513140 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review] → [ready to land][waits for dependencies]
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
|
||
Comment 6•14 years ago
|
||
Backed out in http://hg.mozilla.org/mozilla-central/rev/dd9ba28d2bd9 to resolve bug 655860.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•14 years ago
|
||
The regression wasn't caused by these patches. Re-landed:
http://hg.mozilla.org/mozilla-central/rev/9e265e80c3ff
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•