Closed Bug 634088 Opened 9 years ago Closed 9 years ago

Use native rendering for indeterminate progress bar (Cocoa)

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 2 obsolete files)

The widget is ready for that but it would required looking at the content states. Should be easy.
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #512730 - Flags: review?(mstange)
Depends on: 633913
Whiteboard: [needs review]
Comment on attachment 512730 [details] [diff] [review]
Patch v1

Looks good, but please request another review from roc because I'm not a peer for the xpwidgets code.

One thing: I'm not sure whether you should bother with the content null check since we mostly skip it in the rest of the file. The only cases when I've seen frames with null content was during frame destruction and when the frame is an nsViewportFrame, and none of those cases can be hit in native theme drawing as far as I know.
Attachment #512730 - Flags: review?(mstange) → review+
Attached patch Patch v1.1 (obsolete) — Splinter Review
r=mstange
Attachment #512730 - Attachment is obsolete: true
Attachment #512748 - Flags: review?(roc)
Attached patch Patch v1.2Splinter Review
I realized I should use nsWidgetAtoms intsead of nsGkAtoms.
Attachment #512748 - Attachment is obsolete: true
Attachment #513140 - Flags: review?(roc)
Attachment #512748 - Flags: review?(roc)
Blocks: 634086
Whiteboard: [needs review] → [ready to land][waits for dependencies]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/00d5a081d5d3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
Depends on: 655860
Backed out in http://hg.mozilla.org/mozilla-central/rev/dd9ba28d2bd9 to resolve bug 655860.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The regression wasn't caused by these patches. Re-landed:
http://hg.mozilla.org/mozilla-central/rev/9e265e80c3ff
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
No longer depends on: 655860
You need to log in before you can comment on or make changes to this bug.