63411 - need twisties in the account manager tree

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

In the Mail/News accounts window, it would be nice if we differentiated between
the types of accounts visually, either by a highlight or perhaps just bold text.

This would go on the Mail for [e-mail], right above the server entry.

Comment 1

[jglick]

At a minimum the Account should have a twisty to the left of its name, (which 
helps distinguish between accounts) so its sub-items (Server and Copies and 
Folders) can be collapsed. (the same as Preferences).  

Using NS RTM build, twisties are not visible.

Comment 2

[(not reading, please use [e-mail] instead)]

weird.  it is a tree, and it used to have twisties and be expanded by default.

I'll have to investigate when and why those went away.

jglick, I'd like to see us have server icons to the left of the account name,
like we do in the thread pane.

how does that sound to you?

adding account manager qa guru to the cc list.

Comment 3

[jglick]

Server icons (Mail or News server) in addition to the twisties would be great!

Comment 4

[(not reading, please use [e-mail] instead)]

over to racham

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

nominating for nsbeta1

Comment 6

[scottputterman]

marking nsbeta1-

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Jennifer made a mock-up for the "ability to re-order accounts" bug, and in 
doing so, she had the twisties in place in the account manager.  Here's the 
shot.

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Twisties showing up expanded (might be collapsed by default)

Comment 9

[timeless]

twisties look good :-)

Comment 10

[Joe Hewitt (gone)]

Initially this problem looked like a xul-related issue, but I traced it down to
an issue with the account manager datasource.  In order for twisties to show up
on this tree, the "container" and "empty" attributes need to be set on the
treeitems.  In order for these to show up, the datasource needs to implement the
HasArcOut method of the nsIRDFDataSource interface.  Currently, the class
nsMsgAccountManagerDS inherits a ::HasArcOut method which always returns false.

Once ::HasArcOut returns true/false at appropriate times, the twisties will
automatically show up without any xul changes to AccountManager.xul.

Comment 11

[Håkan Waara]

Would be nice if someone fixed this soon..

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

updating severity, this would be a great addition to the account manager.

Comment 13

[(not reading, please use [e-mail] instead)]

updating summary.

Comment 14

[(not reading, please use [e-mail] instead)]

remember, the folder pane also uses the account manager datasource

so we have to be careful that making the twisties show up in the account 
manager doesn't make them show up in the folder pane when they shouldn't.

hewitt: about using "empty" and "container" directly, I didn't have to do that 
for my subscribe datasource.  I used #Child property and implemented HasArcOut
(), HasAssertion() etc.

but either way, if we make the panels children of the account, it might mess up 
the folder pane.

Comment 15

[(not reading, please use [e-mail] instead)]

using the Child property alonem having "Server" and "Copies and Folders" as 
children of the server might make them show up in the folder pane, too.

proceed with caution.

Comment 16

[(not reading, please use [e-mail] instead)]

I take that back.  after working it out over irc, I think I have a rought draft 
of a fix.

Comment 17

[(not reading, please use [e-mail] instead)]

Attachment: rough draft, gets twisties in account manager

Comment 18

[(not reading, please use [e-mail] instead)]

ignore the white space issues.

here's the problem, I'm duplicating some code from 
nsMsgAccountManagerDataSource::createSettingsResources()

the two have to match up.

I could call createSettingsResources() and then check the size of the array.

Comment 19

[(not reading, please use [e-mail] instead)]

taking.

I'll finish up the fix and get it in.

then I'll look for (or log) a bug on having it so all accounts are closed except
the selected one.

Comment 20

[(not reading, please use [e-mail] instead)]

fixed.

this should open the door for some ui improvements.

Comment 21

[jglick]

Seth, looks great! Thanks. :-)

Stephen, if you still want Server icons (Mail or News server) in addition to the 
twisties, file another bug?  

Comment 22

[Ninoschka Baca]

Build 2001-05-11-04: WinMe
Build 2001-05-11-09: Mac 9.04
Build 2001-05-11-08: Linux RH 6.2
Verified.