634158 - The resizer is displayed in the wrong position on orphan tabs

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Raymond Lee [:raymondlee]]

It happens in the latest trunk.

Steps to reproduce
1. Drag a tab item from a group to an empty space to create an orphan tabs

Expected result:
The resizer appears at the bottom right of the orphan tab

Actual result:
The resizer appears at the top right of the orphan tab

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: Screenshot

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Do we need a test for this?

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 512410 [details] [diff] [review]
patch v1

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=0a100b7fa1ff

Comment 5

[Ian Gilman [:iangilman]]

Comment on attachment 512410 [details] [diff] [review]
patch v1

Seems like a test would be pretty straight-forward: create an orphan and check the location of its resizer. Might as well give it a shot.

Otherwise looks good.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2 (with test)

Comment 7

[Ian Gilman [:iangilman]]

Comment on attachment 512611 [details] [diff] [review]
patch v2 (with test)

Beautiful!

Nice use of registerCleanupFunction, by the way. Another thing to consider (for next time) is to add one last registerCleanupFunction right before the finish() that verifies the ending state.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 512611 [details] [diff] [review]
patch v2 (with test)

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=2baab618efbe

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 512611 [details] [diff] [review]
patch v2 (with test)

a=beltzner

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 11

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/8bad52b42fc1

Comment 12

[Tracy Walker [:tracy]]

verified with minefield build of 20110217

Comment 13

[Ian Gilman [:iangilman]]

Looks like this has landed; removing the "checkin-needed" keyword