Closed
Bug 634310
Opened 14 years ago
Closed 14 years ago
Make index.cgi compliant with WAI
Categories
(Bugzilla :: User Interface, enhancement)
Bugzilla
User Interface
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: timello, Assigned: fdonalisio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
3.39 KB,
patch
|
timello
:
review+
|
Details | Diff | Splinter Review |
We should change the index page to make it complaint with W3C Web Accessibility Initiative.
|
Reporter | |
Updated•14 years ago
|
Summary: Make index.cgi complaint with WAI → Make index.cgi compliant with WAI
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #512836 -
Flags: review?(timello)
|
||
Updated•14 years ago
|
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 512836 [details] [diff] [review]
Remove WCAG 2.0 violations in the index.cgi
>=== modified file 'template/en/default/global/header.html.tmpl'
>-<html>
>+<html lang="en" xml:lang="en">
Does this pass HTML 4.01 Transitional tests?
|
|
Assignee | |
Comment 3•14 years ago
|
||
Implements the following W3C accessibility techniques:
-Using language attributes on the html element http://www.w3.org/TR/2010/NOTE-WCAG20-TECHS-20101014/H57
-Using the title attribute to identify form controls when the label element cannot be used http://www.w3.org/TR/WCAG20-TECHS/H65.html
-Failure of Success Criterion 1.3.1 and 4.1.2 due to the association of label and user interface controls not being programmatically determinable http://www.w3.org/TR/WCAG20-TECHS/F68.html
Attachment #512836 -
Attachment is obsolete: true
Attachment #513421 -
Flags: review?(timello)
Attachment #512836 -
Flags: review?(timello)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Now it does.
(In reply to comment #2)
> Comment on attachment 512836 [details] [diff] [review]
> Remove WCAG 2.0 violations in the index.cgi
>
> >=== modified file 'template/en/default/global/header.html.tmpl'
>
> >-<html>
> >+<html lang="en" xml:lang="en">
>
> Does this pass HTML 4.01 Transitional tests?
|
|
Reporter | |
Comment 5•14 years ago
|
||
Comment on attachment 513421 [details] [diff] [review]
Remove WCAG 2.0 violations in the index.cgi
>=== modified file 'template/en/default/index.html.tmpl'
>--- template/en/default/index.html.tmpl 2011-01-05 10:35:10 +0000
>+++ template/en/default/index.html.tmpl 2011-02-17 17:10:23 +0000
>@@ -74,6 +74,8 @@
> //-->
> </script>
>
>+
>+
These new lines are not needed. But can be fixed in the checkin. Otherwise, it looks good!
It passes in all tests.
Thanks Francisco!
Attachment #513421 -
Flags: review?(timello) → review+
|
|
Reporter | |
Updated•14 years ago
|
Flags: approval?
|
|
||
Updated•14 years ago
|
Target Milestone: --- → Bugzilla 4.2
|
|
||
Updated•14 years ago
|
Flags: approval? → approval+
|
|
Reporter | |
Comment 6•14 years ago
|
||
Committing to: bzr+ssh://timello%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/index.html.tmpl
modified template/en/default/account/auth/login-small.html.tmpl
modified template/en/default/global/common-links.html.tmpl
modified template/en/default/global/header.html.tmpl
Committed revision 7745.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•14 years ago
|
||
Woohoo! Thanks Francisco! :-)
You need to log in
before you can comment on or make changes to this bug.
Description
•