635202 - Make Simple search page compliant with WAI

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Francisco Donalisio]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101206 Ubuntu/10.10 (CK-IBM) (CK-IBM) Firefox/3.6.13
Build Identifier: 

We should change the Simple search page to make it complaint with W3C Web Accessibility Initiative.

Reproducible: Always

Comment 1

[Francisco Donalisio]

Attachment: Remove WCAG 2.0 violations in the simple search page

Implements the W3C accessibility technique - Separating information and structure from presentation to enable different presentations - http://www.w3.org/TR/WCAG20-TECHS/G140.html

Comment 2

[Francisco Donalisio]

Attachment: Remove WCAG 2.0 violations in the simple search page

Comment 3

[Tiago Mello [:timello]]

Comment on attachment 514225 [details] [diff] [review]
Remove WCAG 2.0 violations in the simple search page

>=== modified file 'skins/contrib/Dusk/global.css'

> /* other */
> 
>+.bz_simple_search th {
>+    text-align: right;
>+} 
>+

It should be in skins/standard/global.css instead or maybe even better in skins/standard/search_form.css

and maybe call it: bz_simple_search_form

>=== modified file 'template/en/default/search/search-specific.html.tmpl'
>--- template/en/default/search/search-specific.html.tmpl	2009-07-20 04:17:40 +0000
>+++ template/en/default/search/search-specific.html.tmpl	2011-02-22 19:13:55 +0000
>@@ -38,15 +38,16 @@
> for "crash secure SSL flash".
> </p>
> 
>+<div class="bz_simple_search">

Instead of this, why don't you just add it in:

  <table summary="Search fields" class="bz_simple_search">


Then we don't need to add a new <div>.

>+    <th>
>+      <label for="content">Words:</label>
>+    </th>
>     <td>
>       <input name="content" size="40" id="content"
>              value="[% default.content.0 FILTER html %]">

Aren't we missing the 'title' for this text field?

Comment 4

[Francisco Donalisio]

Attachment: Remove WCAG 2.0 violations in the simple search page

Comment 5

[Francisco Donalisio]

(In reply to comment #3)
> Comment on attachment 514225 [details] [diff] [review]
> Remove WCAG 2.0 violations in the simple search page
> 
> >=== modified file 'skins/contrib/Dusk/global.css'
> 
> > /* other */
> > 
> >+.bz_simple_search th {
> >+    text-align: right;
> >+} 
> >+
> 
> It should be in skins/standard/global.css instead or maybe even better in
> skins/standard/search_form.css
> 
> and maybe call it: bz_simple_search_form
> 
> >=== modified file 'template/en/default/search/search-specific.html.tmpl'
> >--- template/en/default/search/search-specific.html.tmpl	2009-07-20 04:17:40 +0000
> >+++ template/en/default/search/search-specific.html.tmpl	2011-02-22 19:13:55 +0000
> >@@ -38,15 +38,16 @@
> > for "crash secure SSL flash".
> > </p>
> > 
> >+<div class="bz_simple_search">
> 
> Instead of this, why don't you just add it in:
> 
>   <table summary="Search fields" class="bz_simple_search">
> 
> 
> Then we don't need to add a new <div>.
> 
> >+    <th>
> >+      <label for="content">Words:</label>
> >+    </th>
> >     <td>
> >       <input name="content" size="40" id="content"
> >              value="[% default.content.0 FILTER html %]">
> 
> Aren't we missing the 'title' for this text field?
The 'title' is not required if there is a label for the input.

Comment 6

[Tiago Mello [:timello]]

Comment on attachment 518031 [details] [diff] [review]
Remove WCAG 2.0 violations in the simple search page

It looks good!

Thanks Francisco!

Comment 7

[Max Kanat-Alexander]

Also, I have given Francisco editbugs so he can assign things to himself.

Comment 8

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified skins/standard/search_form.css
modified template/en/default/search/search-specific.html.tmpl
Committed revision 7770.