make package: "Warning: package error or possible missing or unnecessary file: bin/components/suitebrowser.xpt (package-manifest, 171)."

VERIFIED FIXED in seamonkey2.1b3

Status

SeaMonkey
Build Config
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.1b3
x86
Windows 2000
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Affected builds: build + leak + nightly.

This was missed in bug 621532.
Flags: in-testsuite-
(Assignee)

Comment 1

6 years ago
Created attachment 512623 [details] [diff] [review]
(Av1) Remove obsolete suitebrowser.*
Attachment #512623 - Flags: review?(bugspam.Callek)

Updated

6 years ago
Attachment #512623 - Flags: review?(bugspam.Callek) → review+

Updated

6 years ago
Attachment #512623 - Flags: review+ → review-
Comment on attachment 512623 [details] [diff] [review]
(Av1) Remove obsolete suitebrowser.*

SuiteBrowser.manifest needs to stay.
(Assignee)

Comment 3

6 years ago
Created attachment 513126 [details] [diff] [review]
(Av2) Stop packaging obsolete suitebrowser.xpt
[Checked in: Comment 5]

Av1, with comment 2 suggestion(s).


(In reply to comment #2)
> SuiteBrowser.manifest needs to stay.

I had removed it +/- "optimistically".
Could you teach me why it's still needed?
(I should have asked before, sorry.)
Attachment #512623 - Attachment is obsolete: true
Attachment #513126 - Flags: review?(bugspam.Callek)
Comment on attachment 513126 [details] [diff] [review]
(Av2) Stop packaging obsolete suitebrowser.xpt
[Checked in: Comment 5]

Suitebrowser.manifest needs to stay because it still exists and does more things.

http://mxr.mozilla.org/comm-central/source/suite/browser/SuiteBrowser.manifest

the .xpt is able to go away because we are no longer creating an idl to use here.
Attachment #513126 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 5

6 years ago
Comment on attachment 513126 [details] [diff] [review]
(Av2) Stop packaging obsolete suitebrowser.xpt
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/dc1fe50d0940
Attachment #513126 - Attachment description: (Av2) Stop packaging obsolete suitebrowser.xpt → (Av2) Stop packaging obsolete suitebrowser.xpt [Checked in: Comment 5]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1298316085.1298325448.15092.gz&fulltext=1
WINNT 5.2 comm-central-trunk build on 2011/02/21 11:21:25

V.Fixed
Status: RESOLVED → VERIFIED
(Assignee)

Comment 7

6 years ago
(In reply to comment #4)
> Suitebrowser.manifest needs to stay because it still exists

Ah, sure, I missed to check that :-<
(Assignee)

Updated

6 years ago
Blocks: 713134
No longer depends on: 515374
You need to log in before you can comment on or make changes to this bug.