Closed Bug 634883 Opened 12 years ago Closed 12 years ago

Inconsistency at Share Link for 'About:' / System pages

Categories

(Firefox for Android Graveyard :: General, defect, P3)

ARM
Maemo
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ioana.chiorean, Assigned: mbrubeck)

Details

(Keywords: ux-consistency)

Attachments

(1 file)

Build id:Mozilla/5.0 (Maemo;Linux armv7l;rv:2.0b12pre)Gecko/20110216 Firefox/4.0b12pre Fennec /4.0b5pre 
Device: N900

Steps to reproduce:
1. Open About:firefox -> press site panel 
2. Go to all pages and press a long tap on about:firefox -> choose share link 
-> Facebook 

Expected result:
- the "about:" / system pages have the share link option disabled

Actual result:
- the Option is present at long tab in all pages

Note:
- the page can't be share cause the url is empty -> enter url page in facebook is generate
- please see : http://www.youtube.com/watch?v=Du5sGbqm9qE
Assignee: nobody → mbrubeck
Priority: -- → P3
This is intentional.  We disable "share link" for the following URI schemes:

  about:
  chrome:
  file:
  javascript:

See bug 584785 for details.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
Yes, I know that is why I thing they also should be disable in Awesome list at long tap.

Expected result:
- the "about:" / system pages should have the share link option disabled.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Attached patch patchSplinter Review
Oops, sorry I misunderstood this bug before.  This patch should fix it.
Attachment #515747 - Flags: review?(mark.finkle)
Keywords: ux-consistency
Attachment #515747 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/4e47e1e2804f

Testing note: This also hides "Open in new tab" for javascript/mailto/news links in the awesomescreen.  (It was already hidden for these links in content.)
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Build id: Mozilla/5.0 (Android;Linux armv7l;rv:2.0b13pre)Gecko/20110301
Firefox/4.0b13pre Fennec /4.0b6pre 

works as expected so I will mark it as Verified Fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.