Closed
Bug 635051
Opened 13 years ago
Closed 13 years ago
revert experienced_first_use to experienced_first_run
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
2.95 KB,
patch
|
Details | Diff | Splinter Review |
Since bug 626791 landed the pref "experienced_first_use" determines whether the "switch to next group" shortcut is active and whether we show the "move to group" context menu items. We should detect in TabView.init() if the user has tabs in multiple groups and set the value accordingly. Upgraders (including me) were confused because some functionality is gone.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → tim.taubert
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 1•13 years ago
|
||
Or just keep calling the pref experienced_first_run, as suggested earlier.
|
|
Assignee | |
Comment 2•13 years ago
|
||
(In reply to comment #1) > Or just keep calling the pref experienced_first_run, as suggested earlier. Would it be ok the rename the preference, only? Renaming the TabView property too would be consistent but is semantically incorrect as "TabView.firstRunExperienced = true" somewhere deep in the code is somewhat confusing.
|
|
||
Comment 3•13 years ago
|
||
Yep.
|
|
Assignee | |
Updated•13 years ago
|
Summary: set experienced_first_use for upgraders (beta/nightly users) → revert experienced_first_use to experienced_first_run
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #513288 -
Flags: review?(ian)
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 513288 [details] [diff] [review] patch v1 Passed try with some intermittent oranges: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=d4a90304867c
|
||
Comment 6•13 years ago
|
||
Comment on attachment 513288 [details] [diff] [review] patch v1 Cool
Attachment #513288 -
Flags: review?(ian) → review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #513288 -
Flags: approval2.0?
|
|
Assignee | |
Comment 7•13 years ago
|
||
Note to approvers: An easy fix that will ensure beta/nightly upgraders that used panorama before will not lose their "move to group" context menu item or "switch to next group" shortcut.
|
||
Comment 8•13 years ago
|
||
Comment on attachment 513288 [details] [diff] [review] patch v1 a=beltzner
Attachment #513288 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 9•13 years ago
|
||
Attachment #513288 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 10•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0f879ec8b3d2
|
||
Comment 12•13 years ago
|
||
Verified with: Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•