635087 - nsCryptoRunnable::Run leaks JSPrincipals

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 513298 [details] [diff] [review]
Fix

Good catch! r=jst, but while you're here, want to add:

  JSAutoEnterCompartment ac;

  if (!ac.enter(cx, realObj)) {
    return NS_ERROR_FAILURE;
  }

right below the JSAutoRequest, and move both lines up top so that doesn't also leak principals? That way we'll ensure that the JS_EvaluateScriptForPrincipals() call always runs in the right compartment.

Comment 2

[Michael Wu [:mwu]]

Attachment: Fix, v2

Like this? Unfortunately don't know enough about the js context stack to know if this is ok.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 520778 [details] [diff] [review]
Fix, v2

Yup, that looks right to me. Thanks! r=jst

Comment 4

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/53ab33f0fd8c

Comment 5

[u279076]

Can someone confirm if this is fixed?