Closed Bug 635362 Opened 10 years ago Closed 10 years ago

Assertion fails when closing group item

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

When closing the "undo close group" or waiting until this is automatically done an assertion fails:

tabview assert: should already be linkedTabItem_setBounds([object Object],false)@chrome://browser/content/tabview.js:5172
GroupItem_arrange_children_each([object Object],0,[object Array])@chrome://browser/content/tabview.js:3562
GroupItem__gridArrange([object Array],[object Object],[object Object])@chrome://browser/content/tabview.js:3556
GroupItem_arrange([object Object])@chrome://browser/content/tabview.js:3419
GroupItem_remove([object Object],[object Object])@chrome://browser/content/tabview.js:3241
([object Object],0,[object Array])@chrome://browser/content/tabview.js:3261
GroupItem_removeAll([object Object])@chrome://browser/content/tabview.js:3260
GroupItem_close((void 0))@chrome://browser/content/tabview.js:2780
GroupItem_destroy()@chrome://browser/content/tabview.js:2972
GroupItem_closeHidden()@chrome://browser/content/tabview.js:2926
()@chrome://browser/content/tabview.js:3051
()@chrome://browser/content/tabview.js:665
(0)@chrome://browser/content/tabview.js:645

As a side-effect the tests for 616729 do not run (but don't fail either). Maybe other tests are affected, too.
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #513598 - Flags: review?(ian)
Comment on attachment 513598 [details] [diff] [review]
patch v1

Good catch!
Attachment #513598 - Flags: review?(ian) → review+
Attachment #513598 - Flags: approval2.0?
Note to approvers:

Very small patch that fixes a typo that causes an ugly error message in the console (and maybe some unexpected behavior we didn't discover yet).
Comment on attachment 513598 [details] [diff] [review]
patch v1

a=beltzner
Attachment #513598 - Flags: approval2.0? → approval2.0+
Attachment #513598 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/f685908ac8f9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Mozilla/5.0 (Windows NT 5.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

Verified issue and it's no longer present.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.