63545 - NNTP posting error takes us to a state where changes don't take effect.

Status: RESOLVED WORKSFORME

(MailNews Core :: Networking: NNTP, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build 2000122108 on Linux, and 2000122105 on Windows NT.

Summary: If you try to post with only a subject only, you get rejected, but
after you get rejected, you still can't post with a subject and a body.

Steps to reproduce:

1. Attempt to post to any NNTP server, with only text in the subject, nothing in
the body.
2. Go through the two dialog boxes that are warning you (NEWS ERROR: NNTP:
article is empty: and then the Sending of Message Failed box).
3. On linux, the compose window gets kicked back to you, on windows you'll have
to restore it from the taskbar.
4. Enter some text in the body of the message now, and hit SEND.

Expected Results:

We should complete the POST.

Actual Results:

You still see the 2 errors in Step #2

Comment 1

[(not reading, please use [e-mail] instead)]

I would not be surprise if you could reproduce this with email.

have a bad smtp server
attempt to compose and and send an email
it fails
edit the message
fix the smtp server setting
change the message
send again.

I bet we send the original message, not the edited message.

just a hunch.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Here's what I did:

Created a new account ([e-mail]) in Netscape 6.
Changed my SMTP server from dredd to mail.earthlink.net.
Attempted to send a message (which fails because I no longer have an account).
Went back to the SMTP server setting and changed it back to dredd.
Added more text to the message, and it sent just fine.

So, it doesn't seem like we're failing to send based on the message state.

NOTE: Earthlink doesn't allow relaying through SMTP, so I never would be able to
send through them from here. (I don't have an account anyway).

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 64572 has been marked as a duplicate of this bug. ***

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 68304 has been marked as a duplicate of this bug. ***

Comment 5

[(not reading, please use [e-mail] instead)]

there are three related issues here

1) 4.x popped up a little alert that had:  "You haven't typed anything, and 
there is no attachment.  Send anyway? [OK] [Cancel]"

2) 4.x seems to allow posting of an empty message.  I'd have to look at the 
code, but it probably inserted an extra blank line if we trying to post an empty 
message.  perhaps we should do the same.

and, the big one:

3) on error, it is possible to get into a state where changes made don't take 
effect.

this bug currently covers #3, which is the dataloss case.

hwaara, if you are interesting in working on this, let me know.

Comment 6

[Håkan Waara]

I guess we should just warn the user that some servers doesn't support empty
messages or possibly prevent the user from sending such messages altogether.

Yes, Seth. If the fix isn't too advanced I'm interested. Please email me further
information on how to fix this if you've got any.

Thanks

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 53240 has been marked as a duplicate of this bug. ***

Comment 8

[scottputterman]

marking nsbeta1+

Comment 9

[scottputterman]

moving to mozilla0.9.1

Comment 10

[scottputterman]

moving to 0.9.2

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

Interesting, with build 2001053004 on Windows 2000, I can't post a message with
only text in the subject using n.p.test on news.mozilla.org, yet I *can post*
that same subject with n.p.test on news.mcom.com.  And I captured this with a
logfile.  Attaching...

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Logfile of both news.mcom.com (works) and news.mozila.org (doesn't)

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

news.mcom.com is: 200 pixie.netscape.com Netscape-Collabra/3.52 17222 NNRP ready
(posting ok).

news.mozilla.org is: 200 secnews.netscape.com Netscape-Collabra/3.52 03615 NNRP
ready (posting ok).

So, both are running the same server software version, which blows away my
theory that some kind of weird server response is going, perhaps.

Comment 14

[scottputterman]

moving to 0.9.3

Comment 15

[scottputterman]

moving to 0.9.4

Comment 16

[(not reading, please use [e-mail] instead)]

slide to 0.9.5

Comment 17

[(not reading, please use [e-mail] instead)]

moving off.

Comment 18

[Håkan Waara]

Upping severity a bit.

Comment 19

[(not reading, please use [e-mail] instead)]

moving to 1.0.1, none of these are 1.0 blockers.

Comment 20

[Brant Gurganus]

By the definitions on <http://bugzilla.mozilla.org/bug_status.html#severity> and
<http://bugzilla.mozilla.org/enter_bug.cgi?format=guided>, crashing and dataloss
bugs are of critical or possibly higher severity.  Only changing open bugs to
minimize unnecessary spam.  Keywords to trigger this would be crash, topcrash,
topcrash+, zt4newcrash, dataloss.

Comment 21

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 22

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 23

[Joshua Cranmer [:jcranmer]]

This still happens on Linux trunk per my fakeserver texts.

And seth, it is a specific server response problem.

Comment 24

[Hartmut Welpmann [:welpy-cw]]

With ESR 128, a 441 Article is empty response from the server is handled as expected.