Make <input type='number'> behaves like <input type='text'>

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
4 months ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

({doc-bug-filed})

Trunk
mozilla16
doc-bug-filed
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 513755 [details] [diff] [review]
Patch v1

This bug is only a step to fix bug 344616.
Attachment #513755 - Flags: review?(jonas)
(Assignee)

Updated

6 years ago
Blocks: 635281
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
Comment on attachment 513755 [details] [diff] [review]
Patch v1

>diff --git a/content/html/content/test/test_bug345512.html b/content/html/content/test/test_bug345512.html
>--- a/content/html/content/test/test_bug345512.html
>+++ b/content/html/content/test/test_bug345512.html
>@@ -286,21 +286,22 @@ function checkPatternValidity(element)
> 
> var input = document.getElementById('i');
> 
> // All input types should have the pattern attribute.
> checkPatternAttribute(input);
> 
> // |validTypes| are the types which accept @pattern
> // and |invalidTypes| are the ones which do not accept it.
>-var validTypes = Array('text', 'password', 'search', 'telephone', 'email', 'url');
>+var validTypes = Array('text', 'password', 'search', 'telephone', 'email',
>+                       'url', 'number');
> var barredTypes = Array('hidden', 'reset', 'button', 'submit', 'image');
> var invalidTypes = Array('checkbox', 'radio', 'file');
> // TODO: 'datetime', 'date', 'month', 'week', 'time', 'datetime-local',
>-//       'number', 'range', ande 'color' do not accept the @pattern too but are
>+//       'range', ande 'color' do not accept the @pattern too but are
> //       not implemented yet.

"ande" -> "and" while you're here?
(Assignee)

Updated

6 years ago
Blocks: 635749
(Assignee)

Comment 2

6 years ago
Created attachment 515611 [details] [diff] [review]
Patch v1.1

Fix typo mentioned in comment 1 and fix a todo that was failing (I would like this patch to pass all tests).
Attachment #513755 - Attachment is obsolete: true
Attachment #513755 - Flags: review?(jonas)
Attachment #515611 - Flags: review?(jonas)
Attachment #515611 - Flags: review?(jonas) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [needs review] → [ready to land][waits for dependencies]
(Assignee)

Updated

6 years ago
No longer blocks: 635749
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/83211311f29d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla16
(Assignee)

Updated

5 years ago
Keywords: dev-doc-needed
See bug 866457 for documentation.
Keywords: dev-doc-needed → doc-bug-filed
See Also: → bug 1342477
You need to log in before you can comment on or make changes to this bug.