Last Comment Bug 635498 - Make <input type='number'> behaves like <input type='text'>
: Make <input type='number'> behaves like <input type='text'>
Status: RESOLVED FIXED
: doc-bug-filed
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: mozilla16
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on:
Blocks: 344616 635281
  Show dependency treegraph
 
Reported: 2011-02-19 08:04 PST by Mounir Lamouri (:mounir)
Modified: 2013-04-27 15:06 PDT (History)
2 users (show)
mounir: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (21.89 KB, patch)
2011-02-19 08:04 PST, Mounir Lamouri (:mounir)
no flags Details | Diff | Splinter Review
Patch v1.1 (24.47 KB, patch)
2011-02-28 07:14 PST, Mounir Lamouri (:mounir)
jonas: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-02-19 08:04:34 PST
Created attachment 513755 [details] [diff] [review]
Patch v1

This bug is only a step to fix bug 344616.
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2011-02-19 09:29:38 PST
Comment on attachment 513755 [details] [diff] [review]
Patch v1

>diff --git a/content/html/content/test/test_bug345512.html b/content/html/content/test/test_bug345512.html
>--- a/content/html/content/test/test_bug345512.html
>+++ b/content/html/content/test/test_bug345512.html
>@@ -286,21 +286,22 @@ function checkPatternValidity(element)
> 
> var input = document.getElementById('i');
> 
> // All input types should have the pattern attribute.
> checkPatternAttribute(input);
> 
> // |validTypes| are the types which accept @pattern
> // and |invalidTypes| are the ones which do not accept it.
>-var validTypes = Array('text', 'password', 'search', 'telephone', 'email', 'url');
>+var validTypes = Array('text', 'password', 'search', 'telephone', 'email',
>+                       'url', 'number');
> var barredTypes = Array('hidden', 'reset', 'button', 'submit', 'image');
> var invalidTypes = Array('checkbox', 'radio', 'file');
> // TODO: 'datetime', 'date', 'month', 'week', 'time', 'datetime-local',
>-//       'number', 'range', ande 'color' do not accept the @pattern too but are
>+//       'range', ande 'color' do not accept the @pattern too but are
> //       not implemented yet.

"ande" -> "and" while you're here?
Comment 2 Mounir Lamouri (:mounir) 2011-02-28 07:14:04 PST
Created attachment 515611 [details] [diff] [review]
Patch v1.1

Fix typo mentioned in comment 1 and fix a todo that was failing (I would like this patch to pass all tests).
Comment 3 Mounir Lamouri (:mounir) 2012-07-05 08:53:01 PDT
https://hg.mozilla.org/mozilla-central/rev/83211311f29d
Comment 4 Florian Scholz [:fscholz] (MDN) 2013-04-27 15:06:55 PDT
See bug 866457 for documentation.

Note You need to log in before you can comment on or make changes to this bug.