635498 - Make <input type='number'> behaves like <input type='text'>

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

This bug is only a step to fix bug 344616.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 513755 [details] [diff] [review]
Patch v1

>diff --git a/content/html/content/test/test_bug345512.html b/content/html/content/test/test_bug345512.html
>--- a/content/html/content/test/test_bug345512.html
>+++ b/content/html/content/test/test_bug345512.html
>@@ -286,21 +286,22 @@ function checkPatternValidity(element)
> 
> var input = document.getElementById('i');
> 
> // All input types should have the pattern attribute.
> checkPatternAttribute(input);
> 
> // |validTypes| are the types which accept @pattern
> // and |invalidTypes| are the ones which do not accept it.
>-var validTypes = Array('text', 'password', 'search', 'telephone', 'email', 'url');
>+var validTypes = Array('text', 'password', 'search', 'telephone', 'email',
>+                       'url', 'number');
> var barredTypes = Array('hidden', 'reset', 'button', 'submit', 'image');
> var invalidTypes = Array('checkbox', 'radio', 'file');
> // TODO: 'datetime', 'date', 'month', 'week', 'time', 'datetime-local',
>-//       'number', 'range', ande 'color' do not accept the @pattern too but are
>+//       'range', ande 'color' do not accept the @pattern too but are
> //       not implemented yet.

"ande" -> "and" while you're here?

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1.1

Fix typo mentioned in comment 1 and fix a todo that was failing (I would like this patch to pass all tests).

Comment 3

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/83211311f29d

Comment 4

[Florian Scholz (Open Web Docs)]

See bug 866457 for documentation.