Closed Bug 635749 Opened 9 years ago Closed 9 years ago
Don't assume we can press ENTER on an <input type='file'> to submit a form
... is that possible on some platforms?
It used to be, for sure.... Now that you can only focus the button, which has its own handler for enter, it might not be possible.
Comment on attachment 514042 [details] [diff] [review] Patch v1 Boris, feel free to review that patch (or decline the review) given that you seem to know about it, according to your previous comment.
Attachment #514042 - Flags: review?(bzbarsky)
Comment on attachment 514042 [details] [diff] [review] Patch v1 r=me
Attachment #514042 - Flags: review?(bzbarsky) → review+
Er, do you still need all that "If this is an enter on the button of a file input" gunk?
I'll r once comment 4 is addressed.
r=bz This is removing the dead code.
Attachment #518111 - Flags: review?(Olli.Pettay) → review+
Whiteboard: [needs review] → [ready to land][waits for dependencies]
No longer depends on: 635498
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.