The default bug view has changed. See this FAQ.

Don't assume we can press ENTER on an <input type='file'> to submit a form

RESOLVED FIXED in mozilla6

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 514042 [details] [diff] [review]
Patch v1

... is that possible on some platforms?
Attachment #514042 - Flags: review?(Olli.Pettay)
It used to be, for sure....  Now that you can only focus the button, which has its own handler for enter, it might not be possible.
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
(Assignee)

Comment 2

6 years ago
Comment on attachment 514042 [details] [diff] [review]
Patch v1

Boris, feel free to review that patch (or decline the review) given that you seem to know about it, according to your previous comment.
Attachment #514042 - Flags: review?(bzbarsky)
Comment on attachment 514042 [details] [diff] [review]
Patch v1

r=me
Attachment #514042 - Flags: review?(bzbarsky) → review+
Er, do you still need all that "If this is an enter on the button of a file input" gunk?

Comment 5

6 years ago
I'll r once comment 4 is addressed.
(Assignee)

Comment 6

6 years ago
Created attachment 518111 [details] [diff] [review]
Patch v2

r=bz

This is removing the dead code.
Attachment #514042 - Attachment is obsolete: true
Attachment #514042 - Flags: review?(Olli.Pettay)
Attachment #518111 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Attachment #518111 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [needs review] → [ready to land][waits for dependencies]
(Assignee)

Comment 7

6 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/c0b7ecc1dc10
No longer depends on: 635498
Flags: in-testsuite-
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.