Closed
Bug 635749
Opened 14 years ago
Closed 14 years ago
Don't assume we can press ENTER on an <input type='file'> to submit a form
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: mounir, Assigned: mounir)
Details
Attachments
(1 file, 1 obsolete file)
|
3.68 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
... is that possible on some platforms?
Attachment #514042 -
Flags: review?(Olli.Pettay)
|
||
Comment 1•14 years ago
|
||
It used to be, for sure.... Now that you can only focus the button, which has its own handler for enter, it might not be possible.
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review]
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 514042 [details] [diff] [review]
Patch v1
Boris, feel free to review that patch (or decline the review) given that you seem to know about it, according to your previous comment.
Attachment #514042 -
Flags: review?(bzbarsky)
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 514042 [details] [diff] [review]
Patch v1
r=me
Attachment #514042 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 4•14 years ago
|
||
Er, do you still need all that "If this is an enter on the button of a file input" gunk?
|
|
Assignee | |
Comment 6•14 years ago
|
||
r=bz
This is removing the dead code.
Attachment #514042 -
Attachment is obsolete: true
Attachment #514042 -
Flags: review?(Olli.Pettay)
Attachment #518111 -
Flags: review?(Olli.Pettay)
|
||
Updated•14 years ago
|
Attachment #518111 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review] → [ready to land][waits for dependencies]
|
|
Assignee | |
Comment 7•14 years ago
|
||
No longer depends on: 635498
Flags: in-testsuite-
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•