Closed Bug 635749 Opened 9 years ago Closed 9 years ago

Don't assume we can press ENTER on an <input type='file'> to submit a form

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
... is that possible on some platforms?
Attachment #514042 - Flags: review?(Olli.Pettay)
It used to be, for sure....  Now that you can only focus the button, which has its own handler for enter, it might not be possible.
Whiteboard: [needs review]
Comment on attachment 514042 [details] [diff] [review]
Patch v1

Boris, feel free to review that patch (or decline the review) given that you seem to know about it, according to your previous comment.
Attachment #514042 - Flags: review?(bzbarsky)
Comment on attachment 514042 [details] [diff] [review]
Patch v1

r=me
Attachment #514042 - Flags: review?(bzbarsky) → review+
Er, do you still need all that "If this is an enter on the button of a file input" gunk?
I'll r once comment 4 is addressed.
Attached patch Patch v2Splinter Review
r=bz

This is removing the dead code.
Attachment #514042 - Attachment is obsolete: true
Attachment #514042 - Flags: review?(Olli.Pettay)
Attachment #518111 - Flags: review?(Olli.Pettay)
Attachment #518111 - Flags: review?(Olli.Pettay) → review+
Whiteboard: [needs review] → [ready to land][waits for dependencies]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/c0b7ecc1dc10
No longer depends on: 635498
Flags: in-testsuite-
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.