Closed
Bug 635733
Opened 13 years ago
Closed 13 years ago
Weird transparency when dragging tabs out of groups
Categories
(Firefox Graveyard :: Panorama, defect, P4)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mitcho, Assigned: mitcho)
References
Details
(Whiteboard: [visual][polish])
Attachments
(2 files, 5 obsolete files)
|
58.09 KB,
image/png
|
faaborg
:
ui-review+
|
Details |
|
914 bytes,
patch
|
Details | Diff | Splinter Review |
Weird transparency
When dragging a tab out of a group, while the tab is still overlapping with the group (technically, before it is removed from the group), its border is oddly transparent. The moment it moves out of the group for real, it gets a nice solid border. When dragging a tab into a group, we don't see this at all. The solution: setting a .tabInGroupItem.focus background-color which matches the background color of the group item itself.
|
Assignee | |
Comment 1•13 years ago
|
||
This only happens on Mac, as pinstrike is the only which makes .tabInGroupItem have a transparent background-color. The solution is simpler than creating a .tabInGroupItem entry... we just need to set the .tabInGroupItem background-color on Mac to match that of the group item itself.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Alex, I'll post a before/after screenshot that you can feedback with.
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Attachment #514030 -
Flags: ui-review?(faaborg)
Attachment #514030 -
Flags: review?(ian)
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Comment on attachment 514030 [details] [diff] [review] Trivial patch Looks good. I don't think we need UI review, since it's just making the behavior consistent across the platforms. I do in general like the idea of flagging the UI folks for look and feel changes, though.
Attachment #514030 -
Flags: ui-review?(faaborg)
Attachment #514030 -
Flags: review?(ian)
Attachment #514030 -
Flags: review+
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 514031 [details]
Before/after
What's a .pxm? Firefox wants me to download it...|
|
Assignee | |
Comment 6•13 years ago
|
||
My bad. Here's a PNG.
Attachment #514028 -
Attachment is obsolete: true
Attachment #514031 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•13 years ago
|
||
Comment on attachment 514030 [details] [diff] [review] Trivial patch Note to approvers: super-lightweight patch for consistent visual treatment on Mac (see before/after image attached), bringing in line with other platforms. r+ Ian.
Attachment #514030 -
Flags: approval2.0?
|
||
Updated•13 years ago
|
Attachment #514054 -
Flags: ui-review+
|
||
Comment 8•13 years ago
|
||
Comment on attachment 514030 [details] [diff] [review] Trivial patch a=beltzner
Attachment #514030 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 9•13 years ago
|
||
Attachment #514054 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•13 years ago
|
Attachment #514054 -
Attachment is obsolete: false
|
|
Assignee | |
Updated•13 years ago
|
Attachment #514030 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 10•13 years ago
|
||
Attachment #514265 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•13 years ago
|
||
Attachment #514532 -
Attachment is obsolete: true
|
||
Comment 12•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/aeace4a142e2
|
||
Comment 13•13 years ago
|
||
WFM on (Windows 7): Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•