Weird transparency when dragging tabs out of groups

RESOLVED FIXED

Status

defect
P4
normal
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: mitcho, Assigned: mitcho)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [visual][polish])

Attachments

(2 attachments, 5 obsolete attachments)

Posted image Weird transparency (obsolete) —
When dragging a tab out of a group, while the tab is still overlapping with the group (technically, before it is removed from the group), its border is oddly transparent. The moment it moves out of the group for real, it gets a nice solid border. When dragging a tab into a group, we don't see this at all.

The solution: setting a .tabInGroupItem.focus background-color which matches the background color of the group item itself.
This only happens on Mac, as pinstrike is the only which makes .tabInGroupItem have a transparent background-color. The solution is simpler than creating a .tabInGroupItem entry... we just need to set the .tabInGroupItem background-color on Mac to match that of the group item itself.
Posted patch Trivial patch (obsolete) — Splinter Review
Alex, I'll post a before/after screenshot that you can feedback with.
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Attachment #514030 - Flags: ui-review?(faaborg)
Attachment #514030 - Flags: review?(ian)
Posted file Before/after (obsolete) —
Comment on attachment 514030 [details] [diff] [review]
Trivial patch

Looks good. I don't think we need UI review, since it's just making the behavior consistent across the platforms. I do in general like the idea of flagging the UI folks for look and feel changes, though.
Attachment #514030 - Flags: ui-review?(faaborg)
Attachment #514030 - Flags: review?(ian)
Attachment #514030 - Flags: review+
Comment on attachment 514031 [details]
Before/after

What's a .pxm? Firefox wants me to download it...
Posted image Before/after
My bad. Here's a PNG.
Attachment #514028 - Attachment is obsolete: true
Attachment #514031 - Attachment is obsolete: true
Comment on attachment 514030 [details] [diff] [review]
Trivial patch

Note to approvers: super-lightweight patch for consistent visual treatment on Mac (see before/after image attached), bringing in line with other platforms. r+ Ian.
Attachment #514030 - Flags: approval2.0?
Comment on attachment 514030 [details] [diff] [review]
Trivial patch

a=beltzner
Attachment #514030 - Flags: approval2.0? → approval2.0+
Posted patch Patch for checkin (obsolete) — Splinter Review
Attachment #514054 - Attachment is obsolete: true
Attachment #514054 - Attachment is obsolete: false
Attachment #514030 - Attachment is obsolete: true
Attachment #514265 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/aeace4a142e2
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Comment 13

8 years ago
WFM on (Windows 7):
Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.