Support more common ms-word extensions for the missing attachment query

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Usul, Assigned: jyeo)

Tracking

(Depends on: 1 bug)

Trunk
Thunderbird 11.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
spun off bug 633818 

.xls and .ppt (maybe .rtf and
.pps)

Comment 1

6 years ago
Wondering about the these days more common ".docx" I've tried on trunk if it's recognized, and found that it isn't (thus adding to my concern in bug 633818 comment #3 about having the "normal" keywords clouded by file extensions).

It actually didn't even find "bla.doc", but only "bla .doc" with a space, so
that feature appears a bit broken on trunk anyway if only exact keywords are found for the purpose of file-extension matching. Is this a known issue?

[Windows+Linux 20110217 build]

Comment 2

6 years ago
(that's probably covered in bug 547589, but makes the file-type list extension
 moot if only an exact ".xls" is allowed to be typed in for a match...)

Comment 3

6 years ago
Filed comment #1 as bug 635993.
seems like a good move to me
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 5

6 years ago
Created attachment 569651 [details] [diff] [review]
635938#1.patch
Attachment #569651 - Flags: review?
(Reporter)

Updated

6 years ago
Assignee: ludovic → jasonyeo88
(Reporter)

Updated

6 years ago
Attachment #569651 - Flags: review? → review?(bwinton)
Comment on attachment 569651 [details] [diff] [review]
635938#1.patch

Review of attachment 569651 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little surprised at the missing ".docx", which I'm seeing more and more of, but this feels like an improvement, so r=me.

Thanks,
Blake.
Attachment #569651 - Flags: review?(bwinton) → review+
(Reporter)

Comment 7

6 years ago
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #6)
> Comment on attachment 569651 [details] [diff] [review] [diff] [details] [review]
> 635938#1.patch
> 
> Review of attachment 569651 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> I'm a little surprised at the missing ".docx", which I'm seeing more and
> more of, but this feels like an improvement, so r=me.
> 
> Thanks,
> Blake.

if this is ok can we rediscuss bug 633818 ?
(Reporter)

Updated

6 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/43e23be10e39
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in before you can comment on or make changes to this bug.