635938 - Support more common ms-word extensions for the missing attachment query

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Ludovic Hirlimann [:Usul]]

spun off bug 633818 

.xls and .ppt (maybe .rtf and
.pps)

Comment 1

[rsx11m]

Wondering about the these days more common ".docx" I've tried on trunk if it's recognized, and found that it isn't (thus adding to my concern in bug 633818 comment #3 about having the "normal" keywords clouded by file extensions).

It actually didn't even find "bla.doc", but only "bla .doc" with a space, so
that feature appears a bit broken on trunk anyway if only exact keywords are found for the purpose of file-extension matching. Is this a known issue?

[Windows+Linux 20110217 build]

Comment 2

[rsx11m]

(that's probably covered in bug 547589, but makes the file-type list extension
 moot if only an exact ".xls" is allowed to be typed in for a match...)

Comment 3

[rsx11m]

Filed comment #1 as bug 635993.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

seems like a good move to me

Comment 5

[Jason Yeo[:jyeo]]

Attachment: 635938#1.patch

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 569651 [details] [diff] [review]
635938#1.patch

Review of attachment 569651 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little surprised at the missing ".docx", which I'm seeing more and more of, but this feels like an improvement, so r=me.

Thanks,
Blake.

Comment 7

[Ludovic Hirlimann [:Usul]]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #6)
> Comment on attachment 569651 [details] [diff] [review] [diff] [details] [review]
> 635938#1.patch
> 
> Review of attachment 569651 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> I'm a little surprised at the missing ".docx", which I'm seeing more and
> more of, but this feels like an improvement, so r=me.
> 
> Thanks,
> Blake.

if this is ok can we rediscuss bug 633818 ?

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/43e23be10e39