Last Comment Bug 635938 - Support more common ms-word extensions for the missing attachment query
: Support more common ms-word extensions for the missing attachment query
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Message Compose Window (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 11.0
Assigned To: Jason Yeo[:jyeo]
:
Mentors:
Depends on: 633818
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-22 11:05 PST by Ludovic Hirlimann [:Usul]
Modified: 2011-12-09 06:00 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
635938#1.patch (1.17 KB, patch)
2011-10-26 05:53 PDT, Jason Yeo[:jyeo]
bwinton: review+
Details | Diff | Review

Description Ludovic Hirlimann [:Usul] 2011-02-22 11:05:02 PST
spun off bug 633818 

.xls and .ppt (maybe .rtf and
.pps)
Comment 1 rsx11m 2011-02-22 12:43:52 PST
Wondering about the these days more common ".docx" I've tried on trunk if it's recognized, and found that it isn't (thus adding to my concern in bug 633818 comment #3 about having the "normal" keywords clouded by file extensions).

It actually didn't even find "bla.doc", but only "bla .doc" with a space, so
that feature appears a bit broken on trunk anyway if only exact keywords are found for the purpose of file-extension matching. Is this a known issue?

[Windows+Linux 20110217 build]
Comment 2 rsx11m 2011-02-22 12:50:33 PST
(that's probably covered in bug 547589, but makes the file-type list extension
 moot if only an exact ".xls" is allowed to be typed in for a match...)
Comment 3 rsx11m 2011-02-22 14:08:02 PST
Filed comment #1 as bug 635993.
Comment 4 Bryan Clark (DevTools PM) [@clarkbw] 2011-03-02 17:10:05 PST
seems like a good move to me
Comment 5 Jason Yeo[:jyeo] 2011-10-26 05:53:37 PDT
Created attachment 569651 [details] [diff] [review]
635938#1.patch
Comment 6 Blake Winton (:bwinton) (:☕️) (PTO 'til London. Find me there for quick answers!) 2011-11-09 08:14:39 PST
Comment on attachment 569651 [details] [diff] [review]
635938#1.patch

Review of attachment 569651 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little surprised at the missing ".docx", which I'm seeing more and more of, but this feels like an improvement, so r=me.

Thanks,
Blake.
Comment 7 Ludovic Hirlimann [:Usul] 2011-11-09 08:19:48 PST
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #6)
> Comment on attachment 569651 [details] [diff] [review] [diff] [details] [review]
> 635938#1.patch
> 
> Review of attachment 569651 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> I'm a little surprised at the missing ".docx", which I'm seeing more and
> more of, but this feels like an improvement, so r=me.
> 
> Thanks,
> Blake.

if this is ok can we rediscuss bug 633818 ?
Comment 8 Mark Banner (:standard8) 2011-12-09 06:00:24 PST
Checked in: http://hg.mozilla.org/comm-central/rev/43e23be10e39

Note You need to log in before you can comment on or make changes to this bug.