636408 - When opening stack window the titles of the website are not visible

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[George Carstoiu]

Attachment: Screenshot 1

Mozilla/5.0 (X11; Linux i686; rv:2.0b13pre) Gecko/20110223 Firefox/4.0b13pre

While in Panorama, after pressing the expand button of a stacked group, the titles of the websites are not visible - dark colored. (See Screenshot 1)

Reproducible: always

Steps to reproduce:
1. Create a few tabs
2. Go to Panorama and create a stack
3. Press expand button and observe the titles of the websites

Actual results:
 - the titles of the websites cannot be read - low visibility

Expected results:
 - titles have a good visibility

Comment 1

[Kevin Hanes]

Seems like if we can get a trivial patch for this, we'd want it for final

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

>-  color: WindowText;
>+  color: #EEE;

Changing color from WindowText to #EEE because the expanded-overlay's background is always black (with some opacity). WindowText is pretty dark in the standard Ubuntu theme (see screenshot).

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 515044 [details] [diff] [review]
patch v1

Note: #EEE is also used in pinstripe and winstripe theme.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 515044 [details] [diff] [review]
patch v1

Seems good. Can you post a screenshot (with patch applied) too, Tim?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Screenshot (with patch applied)

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 515044 [details] [diff] [review]
patch v1

Note to approvers:

Non-risk one-line CSS change that vastly improves the readability of tab titles for expanded stacks.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Attachment: [checked-in] patch for checkin

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 515732 [details] [diff] [review]
[checked-in] patch for checkin

http://hg.mozilla.org/mozilla-central/rev/0914f594bfb0

Comment 9

[George Carstoiu]

Verified with: Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0