Last Comment Bug 636788 - Adapt Link Behavior pref pane after |Bug 583625 - Consider adding UI for pref browser.link.open_newwindow.restriction| and |Bug 505311 - SeaMonkey should default to tabbed browsing|
: Adapt Link Behavior pref pane after |Bug 583625 - Consider adding UI for pref...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Help Documentation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
:
Mentors:
Depends on: 505311 583625
Blocks: 636993
  Show dependency treegraph
 
Reported: 2011-02-25 11:13 PST by Jens Hatlak (:InvisibleSmiley)
Modified: 2011-02-27 10:25 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (3.89 KB, patch)
2011-02-25 11:13 PST, Jens Hatlak (:InvisibleSmiley)
no flags Details | Diff | Splinter Review
patch v2 [Checkin: comment 4] (3.79 KB, patch)
2011-02-27 04:52 PST, Jens Hatlak (:InvisibleSmiley)
stefanh: review+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2011-02-25 11:13:44 PST
Created attachment 515135 [details] [diff] [review]
patch

The Link Behavior pref pane is outdated, see bug 583625 and bug 505311. I think our minimal goal for 2.1 should be up-to-date docs for Preferences, and I thought I might set a good example. Come one guys, we can do this! :-)

Hint: http://kb.mozillazine.org/Browser.link.open_newwindow.restriction (the order in our UI is 0, 2, 1)
Comment 1 Stefan [:stefanh] 2011-02-26 07:13:55 PST
Comment on attachment 515135 [details] [diff] [review]
patch

+          <li><strong>Don&apos;t divert custom windows into tabs</strong>: Open
+            the page to be loaded in a popup window if the JavaScript call
+            included a features parameter, else open the page in a tab according
+            to the above settings. (This is the default.)</li>

This might be a bit too technical, I think. Perhaps something like this (you get the idea):

"Open a new window if the script includes information on how the new window should be displayed, else"

Or "Open a new window if the script have specified any features of the new window, else"


Also, I see that there's a lot of "This is the default". I don't think we need those, but if you feel strongly about it, feel free to leave them there. I just think that it might add a maintenance problem, since we don't know if we change the defaults in the future ;-)
Comment 2 Jens Hatlak (:InvisibleSmiley) 2011-02-27 04:52:54 PST
Created attachment 515461 [details] [diff] [review]
patch v2 [Checkin: comment 4]
Comment 3 Stefan [:stefanh] 2011-02-27 05:09:42 PST
Comment on attachment 515461 [details] [diff] [review]
patch v2 [Checkin: comment 4]

+            the page to be loaded in a popup window if the script explicitly
+            specified features of the new window (such as size or position)

Should it really be "specified" (compare "open", "to be loaded")?
Comment 4 Jens Hatlak (:InvisibleSmiley) 2011-02-27 10:24:38 PST
Comment on attachment 515461 [details] [diff] [review]
patch v2 [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/1980c32b1afa
with tense comment 3 addressed

Note You need to log in before you can comment on or make changes to this bug.