63698 - Context menu with empty submenu for personal toolbar items

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Blake Ross]

Build ID: 12/24 trunk (tip)

Steps to Reproduce:

(1) Right click on any item in the personal toolbar.

Result: you get a context menu with one empty submenu.

Alec, someone on IRC said your inclusion of nsTreeUtils.js in bookmarks.xul 
caused this somehow.

Comment 1

[Blake Ross]

*** Bug 63725 has been marked as a duplicate of this bug. ***

Comment 2

[Alec Flett]

Attachment: remove contextual menu from toolbar (was never used anyway)

Comment 3

[Alec Flett]

the contextual menu was never used anyway, because fillContextMenu() would
always verify that the target of the context menu was a tree..

also in this patch is the removal of bookmarks.js - we no longer need it because
I have re-factored the bookmarks code.

looking for a r/sr, adding ben

Comment 4

[Blake Ross]

r=blake

Comment 5

[sairuh (rarely reading bugmail)]

pardon the spam: personal toolbar bugs should go into the Bookmarks component.
so, i'm moving the existing ones from xp apps/xp apps: gui to there...

Comment 6

[Fabian Guisset]

*** Bug 64021 has been marked as a duplicate of this bug. ***

Comment 7

[Håkan Waara]

*** Bug 64021 has been marked as a duplicate of this bug. ***

Comment 8

[Asa Dotzler [:asa]]

carrying over nav triage team comment from bug 64021 in case anyone cares.

------- Additional Comments From [e-mail] 2001-01-04 16:11 -------

Netscape Nav triage team: this is a Netscape beta stopper.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

hm. I'll be needing to monkey around with this function a bit for bookmarks, as 
the commands that need to be in the context menus aren't all stored in the 
bookmarks service. I may define a different mechanism for creating context menus 
for bookmarks, which will be shared by the bookmarks window, panel and toolbar. 

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 11

[R.K.Aa.]

*** Bug 64976 has been marked as a duplicate of this bug. ***

Comment 12

[Alec Flett]

fix is in.

Comment 13

[Håkan Waara]

Seems like Ben never fixed this in his rewritten bookmarks stuff, I guess it's
not too hard to make the same changes as this patch does on the new BM stuff?

Adding regression keyword and reopening.

Comment 14

[Alec Flett]

dammit. reassigning to ben then.

Comment 15

[Keyser Sose]

WORKSFORME
Platform: PC
OS: Windows 98
Mozilla Build: 2001022311

drbrain sees them on FreeBSD thus marking FIXED. Scott sees it as well

Comment 16

[Boris Zbarsky [:bzbarsky]]

I'm still seeing an empty menu on current Linux builds (2001-03-14-08 and a
debug build from 2001-03-18).  Reopening.

Comment 17

[Boris Zbarsky [:bzbarsky]]

*** Bug 72445 has been marked as a duplicate of this bug. ***

Comment 18

[timeless]

clobber milestone, clear status.

Comment 19

[Paul Chen]

Marking nsbeta1+, p2, mozilla0.9

Comment 20

[Bradley Baetz]

*** Bug 73585 has been marked as a duplicate of this bug. ***

Comment 21

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 65174 has been marked as a duplicate of this bug. ***

Comment 22

[James Manning]

Verified this behavior with build id 2001041305

output generated on this action:

JavaScript error: 
 line 0: fillContextMenu is not defined

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

This bug is fixed by the patch in 17920. 

Comment 24

[Ben Goodger (use ben at mozilla dot org for email)]

fixed. 

Comment 25

[Claudius Gayle]

VERIFIED Fixed with 200104260x builds on all platforms