"ASSERTION: Default canvas font is invalid" working with fonts on a canvas that has no presshell

RESOLVED FIXED in mozilla5

Status

()

Core
Canvas: 2D
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: Mats Palmgren (vacation - back in August))

Tracking

(Blocks: 2 bugs, {assertion, testcase})

Trunk
mozilla5
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Created attachment 515566 [details]
testcase

###!!! ASSERTION: Default canvas font is invalid: 'res == NS_OK', 
file content/canvas/src/nsCanvasRenderingContext2D.cpp, line 2885
(Reporter)

Comment 1

7 years ago
Created attachment 515567 [details]
stack trace (mac)
(Reporter)

Updated

7 years ago
OS: Windows 7 → All
Hardware: x86 → All
This has nothing to do with moving between frames.  This assert will fire any time you use a <canvas> that's inside a document with no presshell (as in this case).

I personally think the assert is bogus (and that the behavior is possibly semi-bogus too).
Summary: "ASSERTION: Default canvas font is invalid" after moving canvas between frames → "ASSERTION: Default canvas font is invalid" working with fonts on a canvas that has no presshell
Bug 647480 fixes this by muting the assert if there is no pres shell.
Depends on: 647480
It doesn't seem right to simply mute the assert, if the real problem is that we don't know how to deal with the font of a canvas in this situation - shouldn't we be fixing _that_ issue?
Created attachment 523905 [details] [diff] [review]
wip1

I guess we could try harder to create something, also in the
absence of a pres shell...  is that what you're suggesting?
Comment on attachment 523905 [details] [diff] [review]
wip1

I merged this into the patch in bug 647480...
Attachment #523905 - Attachment is obsolete: true
(Reporter)

Comment 7

6 years ago
Seems to have been fixed by the patch in bug 647480.
Assignee: nobody → matspal
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla5
You need to log in before you can comment on or make changes to this bug.