Closed Bug 637245 Opened 15 years ago Closed 15 years ago

"ASSERTION: Default canvas font is invalid" working with fonts on a canvas that has no presshell

Categories

(Core :: Graphics: Canvas2D, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: jruderman, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files, 1 obsolete file)

Attached file testcase
###!!! ASSERTION: Default canvas font is invalid: 'res == NS_OK', file content/canvas/src/nsCanvasRenderingContext2D.cpp, line 2885
Attached file stack trace (mac)
OS: Windows 7 → All
Hardware: x86 → All
This has nothing to do with moving between frames. This assert will fire any time you use a <canvas> that's inside a document with no presshell (as in this case). I personally think the assert is bogus (and that the behavior is possibly semi-bogus too).
Summary: "ASSERTION: Default canvas font is invalid" after moving canvas between frames → "ASSERTION: Default canvas font is invalid" working with fonts on a canvas that has no presshell
Bug 647480 fixes this by muting the assert if there is no pres shell.
Depends on: 647480
It doesn't seem right to simply mute the assert, if the real problem is that we don't know how to deal with the font of a canvas in this situation - shouldn't we be fixing _that_ issue?
Attached patch wip1 (obsolete) — Splinter Review
I guess we could try harder to create something, also in the absence of a pres shell... is that what you're suggesting?
Comment on attachment 523905 [details] [diff] [review] wip1 I merged this into the patch in bug 647480...
Attachment #523905 - Attachment is obsolete: true
Seems to have been fixed by the patch in bug 647480.
Assignee: nobody → matspal
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: