647480 - Crash [@ TextRunWordCache::MakeTextRun] with canvas mozDrawText, mozPathText, mozTextAlongPath

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

###!!! ASSERTION: Default canvas font is invalid: 'res == NS_OK', file content/canvas/src/nsCanvasRenderingContext2D.cpp, line 2941
(like in bug 637245)

Crash [@ TextRunWordCache::MakeTextRun]

Comment 1

[Jesse Ruderman]

Attachment: stack traces

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix

mozPathText() and mozTextAlongPath() also crashes without a font.

Accessing the font, eg "ctx.font", asserts:
###!!! ASSERTION: Default canvas font is invalid: 'res == NS_OK',
file content/canvas/src/nsCanvasRenderingContext2D.cpp, line 2941

Comment 3

[Mats Palmgren (inactive)]

The assertion is bug 637245, which will be fixed by the patch.

Comment 4

[Jonathan Kew [:jfkthame]]

Shouldn't there be a valid default for the font? (10px sans-serif, iirc.) It seems to me like this patch just papers over the problem so that we don't assert or crash, but doesn't actually fix the underlying issue, which is that we apparently don't know how to set up the font without a presshell. We should be fixing that problem, not sweeping it under the carpet, no?

Comment 5

[Mats Palmgren (inactive)]

Attachment: fix v2

Try harder to set up a default font.

Comment 6

[Jonathan Kew [:jfkthame]]

Comment on attachment 523909 [details] [diff] [review]
fix v2

Looks good to me, thanks.

Comment 7

[Mats Palmgren (inactive)]

Fixed in Cedar:
http://hg.mozilla.org/projects/cedar/rev/5384e63ae39e

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/5384e63ae39e

Comment 9

[LegNeato]

We will not be taking this for Macaw. If you disagree, please renominate or
send an email to [e-mail] with additional reasoning.