The default bug view has changed. See this FAQ.

decomtamination: remove nsIPlugin and nsIPluginInstance

VERIFIED FIXED

Status

()

Core
Plug-ins
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 9 obsolete attachments)

(Assignee)

Description

6 years ago
We don't need nsIPlugin or nsIPluginInstance. We should get rid of them.
(Assignee)

Comment 1

6 years ago
Created attachment 515571 [details] [diff] [review]
fix v1.0

Compiles and works for 32-bit Mac OS X. Probably doesn't even compile on other platforms yet.
(Assignee)

Comment 2

6 years ago
This would break non-libxul builds. We should stop making the plugin code its own library and just build it with dom/plugins. I'll file a new bug and make this depend on that.
We are going to intentionally remove the --disable-libxul build configuration post-4.0, FWIW. Fewer configurations to support + more opportunities for deCOM like this.
Blocks: 105431
(Assignee)

Comment 4

6 years ago
Created attachment 519122 [details] [diff] [review]
fix v1.1

Update to current trunk.
Attachment #515571 - Attachment is obsolete: true
Attachment #519122 - Flags: review?(benjamin)
(Assignee)

Comment 5

6 years ago
Created attachment 519146 [details] [diff] [review]
fix v1.2

Linux build fixes.
Attachment #519122 - Attachment is obsolete: true
Attachment #519122 - Flags: review?(benjamin)
Attachment #519146 - Flags: review?(benjamin)
(Assignee)

Updated

6 years ago
Attachment #519146 - Flags: review?(benjamin)
(Assignee)

Updated

6 years ago
Attachment #519146 - Attachment is obsolete: true
(Assignee)

Comment 6

6 years ago
Created attachment 527721 [details] [diff] [review]
remove nsIPlugin, v1.0
Attachment #527721 - Flags: review?(benjamin)
(Assignee)

Comment 7

6 years ago
Created attachment 529114 [details] [diff] [review]
remove nsIPlugin, v1.1
Attachment #527721 - Attachment is obsolete: true
Attachment #527721 - Flags: review?(benjamin)
Attachment #529114 - Flags: review?(benjamin)
(Assignee)

Comment 8

6 years ago
Created attachment 531348 [details] [diff] [review]
remove nsIPlugin, v1.2

A better way to deal with nsPluginHost::GetPlugin.
Attachment #529114 - Attachment is obsolete: true
Attachment #529114 - Flags: review?(benjamin)
Attachment #531348 - Flags: review?(benjamin)
Why still inherit from nsISupports?
(Assignee)

Comment 10

6 years ago
(In reply to comment #9)
> Why still inherit from nsISupports?

I'm planning to stop doing that but I want to limit the size/depth of each patch. I'll get that in another set of patches soon.
Attachment #531348 - Flags: review?(benjamin) → review+
(Assignee)

Comment 11

6 years ago
Created attachment 531637 [details] [diff] [review]
remove nsIPlugin, v1.3

Update to current trunk.
Attachment #531348 - Attachment is obsolete: true
(Assignee)

Comment 12

6 years ago
pushed nsIPlugin interface removal to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/6eb2b03b6fd5
(Assignee)

Comment 13

6 years ago
Created attachment 532028 [details] [diff] [review]
remove nsIPluginInstance, v1.0
(Assignee)

Comment 14

6 years ago
Created attachment 532067 [details] [diff] [review]
remove nsIPluginInstance, v1.1

Linux compile fixes.
Attachment #532028 - Attachment is obsolete: true
(Assignee)

Comment 15

6 years ago
Created attachment 532105 [details] [diff] [review]
remove nsIPluginInstance, v1.2

Windows build fixes.
Attachment #532067 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #532105 - Flags: review?(benjamin)
Attachment #532105 - Flags: review?(benjamin) → review+
(Assignee)

Comment 16

6 years ago
Created attachment 533090 [details] [diff] [review]
remove nsIPluginInstance, v1.3

QT build fixes.
Attachment #532105 - Attachment is obsolete: true
(Assignee)

Comment 17

6 years ago
pushed nsIPluginInstance interface removal to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/5ffdf4967dec
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Depends on: 657868

Comment 18

6 years ago
Setting this as Verified as of #comment 17
Status: RESOLVED → VERIFIED

Comment 19

6 years ago
Created attachment 545072 [details] [diff] [review]
expose nsNPAPIPluginInstance::GetJSContext

Since nsNPAPIPluginInstance isn't an XPCOM component anymore there is no way for a plugin to get the JSContext associated with an instance. This patch try to remedy it. I'm not sure this is the right way to do it.
(Assignee)

Comment 20

6 years ago
Thanks for your contribution, but please file a new bug for any further patches, this bug is closed out and done.

Comment 21

6 years ago
OK. filed: https://bugzilla.mozilla.org/show_bug.cgi?id=670629
Thanks for your help.
You need to log in before you can comment on or make changes to this bug.