Closed Bug 637317 Opened 9 years ago Closed 9 years ago

Re-enable elfhack

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file)

Elfhack was disabled in bug 637243, which we would eventually revert to re-enable elfhack once the underlying problem is fixed in bug 637316.
Depends on: 637341
This applies on top of the patch from bug 637341
Assignee: nobody → mh+mozilla
Attachment #516541 - Flags: review?(ted.mielczarek)
Attachment #516541 - Flags: review?(ted.mielczarek) → review+
Is this going to be re-enabled on mozilla-central?
(In reply to comment #4)
> When we merge.

I need a better answer to provide users of my builds (particulary the 64-bit ones) who are asking why they are so much bigger than they were before and when that will be fixed than "when we merge".
(In reply to comment #5)
> (In reply to comment #4)
> > When we merge.
> 
> I need a better answer to provide users of my builds (particulary the 64-bit
> ones) who are asking why they are so much bigger than they were before and when
> that will be fixed than "when we merge".

Oh.  I had thought this had been checked in in some way that it was in the build system only and not in other peoples builds.  Based on file sizes of recent mozilla-central builds it would appear this is not enabled in nightlies either, so there is really no issue I want to raise here.
This appears to have only re-enabled building elfhack, the resultant builds under Linux seem to still not end up being elfhacked.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The nightlies are very much elfhacked.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
(In reply to comment #9)
> The nightlies are very much elfhacked.

OK.  I see the issue, it is the 64-bit nightlies that are not being elfhacked and those are the ones where it actually had a significant impact.
the 64-bit nightlies are elfhacked.
are you sure you are looking at the 4.2a1pre nightlies ?
Nevermind.  I must have done my find before the log file was completely loaded.
My real issue here (which was that my builds were not being elfhacked) also seems to now be fixed.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.