637317 - Re-enable elfhack

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Elfhack was disabled in bug 637243, which we would eventually revert to re-enable elfhack once the underlying problem is fixed in bug 637316.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Enable elfhack again

This applies on top of the patch from bug 637341

Comment 2

[Mike Hommey [:glandium]]

http://hg.mozilla.org/projects/build-system/rev/850094d1651e

Comment 3

[Bill Gianopoulos [:WG9s]]

Is this going to be re-enabled on mozilla-central?

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

When we merge.

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to comment #4)
> When we merge.

I need a better answer to provide users of my builds (particulary the 64-bit ones) who are asking why they are so much bigger than they were before and when that will be fixed than "when we merge".

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to comment #5)
> (In reply to comment #4)
> > When we merge.
> 
> I need a better answer to provide users of my builds (particulary the 64-bit
> ones) who are asking why they are so much bigger than they were before and when
> that will be fixed than "when we merge".

Oh.  I had thought this had been checked in in some way that it was in the build system only and not in other peoples builds.  Based on file sizes of recent mozilla-central builds it would appear this is not enabled in nightlies either, so there is really no issue I want to raise here.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/850094d1651e

Comment 8

[Bill Gianopoulos [:WG9s]]

This appears to have only re-enabled building elfhack, the resultant builds under Linux seem to still not end up being elfhacked.

Comment 9

[Mike Hommey [:glandium]]

The nightlies are very much elfhacked.

Comment 10

[Bill Gianopoulos [:WG9s]]

(In reply to comment #9)
> The nightlies are very much elfhacked.

OK.  I see the issue, it is the 64-bit nightlies that are not being elfhacked and those are the ones where it actually had a significant impact.

Comment 11

[Mike Hommey [:glandium]]

the 64-bit nightlies are elfhacked.

Comment 12

[Mike Hommey [:glandium]]

are you sure you are looking at the 4.2a1pre nightlies ?

Comment 13

[Bill Gianopoulos [:WG9s]]

Nevermind.  I must have done my find before the log file was completely loaded.

Comment 14

[Bill Gianopoulos [:WG9s]]

My real issue here (which was that my builds were not being elfhacked) also seems to now be fixed.