Closed Bug 637341 Opened 9 years ago Closed 9 years ago

crashsymbols-full's .dbg files come from non-elfhack'ed versions

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: fixed-in-bs)

Attachments

(2 files)

elfhack is applied on libraries during "make package", and only applied on the staging directory. It was made this way in order to allow to apply elfhack on all libraries, including nspr and nss.

make buildsymbols takes files from dist/bin, which means it doesn't take elfhack'ed libraries.

We need to sort out how to solve this before re-enabling elfhack.
This applies elfhack on dist/bin (meaning it will modify e.g. toolkit/library/libxul.so) during make package or make buildsymbols, whichever is called first.
Assignee: nobody → mh+mozilla
Attachment #516539 - Flags: review?(ted.mielczarek)
(to apply with -d build/unix/elfhack -p1 on mozilla-central)

This is mostly a cosmetic patch to avoid confusion when elfhack is being run twice with the other patch from this bug.
Attachment #516540 - Flags: review?(tglek)
Attachment #516540 - Flags: review?(tglek) → review+
Attachment #516539 - Flags: review?(ted.mielczarek) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.