Closed
Bug 637341
Opened 13 years ago
Closed 13 years ago
crashsymbols-full's .dbg files come from non-elfhack'ed versions
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: fixed-in-bs)
Attachments
(2 files)
5.53 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
2.47 KB,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
elfhack is applied on libraries during "make package", and only applied on the staging directory. It was made this way in order to allow to apply elfhack on all libraries, including nspr and nss. make buildsymbols takes files from dist/bin, which means it doesn't take elfhack'ed libraries. We need to sort out how to solve this before re-enabling elfhack.
Assignee | ||
Comment 1•13 years ago
|
||
This applies elfhack on dist/bin (meaning it will modify e.g. toolkit/library/libxul.so) during make package or make buildsymbols, whichever is called first.
Assignee: nobody → mh+mozilla
Attachment #516539 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 2•13 years ago
|
||
(to apply with -d build/unix/elfhack -p1 on mozilla-central) This is mostly a cosmetic patch to avoid confusion when elfhack is being run twice with the other patch from this bug.
Attachment #516540 -
Flags: review?(tglek)
Updated•13 years ago
|
Attachment #516540 -
Flags: review?(tglek) → review+
Updated•13 years ago
|
Attachment #516539 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/build-system/rev/aad612e0b8c9 http://hg.mozilla.org/projects/build-system/rev/bf12fcfef518
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/aad612e0b8c9 http://hg.mozilla.org/mozilla-central/rev/bf12fcfef518
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•