637977 - Under mod_perl, Bugzilla generates URLs with semicolons instead of ampersands

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Max Kanat-Alexander]

This bug has actually been around since the very beginning of our mod_perl support--for some reason, Bugzillas running under mod_perl generate URL query parameters separated by semicolons instead of ampersands. (This only happens when we ask CGI.pm to generate a URL for us.) There is an -oldstyle_urls setting that we are configuring in CGI.pm, but it is apparently not persisting, so we will have to figure out what to do about that.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, this fixes this bug and other long-standing issues (such as us not retaining $SIG{TERM} under mod_perl). Basically the problem was that CGI::_reset_globals was registered as a cleanup handler automatically by CGI.pm. But it didn't properly restore the symbols on every new page load. I've simplified this by always restoring them when we call new(), under mod_perl.

I have tested this and it works.

Comment 2

[:glob ✱]

Comment on attachment 516138 [details] [diff] [review]
v1

r=glob

weird that we haven't seen this problem on bmo, but makes sense.

Comment 3

[Max Kanat-Alexander]

Yeah, I agree that that is weird. I used to see it, for sure. Maybe there's some trickery that is hiding it from us on bmo.

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla.pm
modified Bugzilla/CGI.pm
Committed revision 7751.