For some reason, this warning appears only with Bugzilla 4.1.2, not with 4.0 or older. But it's filling the web server error log and should be fixed before 4.2rc1. As this warning started to appear around March 15 and on trunk only, I suspect the culprit is bug 637977.
Created attachment 534639 [details] [diff] [review] patch, v1 Per perldiag: "The simple rule is: Inheritance will not work when autoloading non-methods. The simple fix for old code is: In any module that used to depend on inheriting AUTOLOAD for non-methods from a base class named BaseClass, execute *AUTOLOAD = \&BaseClass::AUTOLOAD during startup." I also removed what I think is now a useless DESTROY. If I understand things correctly (at least it works during testing), our method is not needed.
Assignee: query-and-buglist → LpSolit
Status: NEW → ASSIGNED
Attachment #534639 - Flags: review?(mkanat)
Comment on attachment 534639 [details] [diff] [review] patch, v1 Looks good to me. I'm not sure that that DESTROY is useless, though. You could confirm by uploading an attachment and then making sure the temp file is actually removed.
Attachment #534639 - Flags: review?(mkanat) → review+
(In reply to comment #2) > Looks good to me. I'm not sure that that DESTROY is useless, though. You > could confirm by uploading an attachment and then making sure the temp file > is actually removed. I just checked on Windows 7, with both 4.0 and 4.1.2, and in both cases is the temporary file still in the Temp\ directory. Looks like we regressed bug 414002 (or CGI.pm never worked on Windows 7).
The regression is tracked in bug 660502. I checked, and removing DESTROY() in Bugzilla/CGI.pm is fine. The temp file is gone after the upload. Committing to: bzr+ssh://email@example.com/bugzilla/trunk/ modified Bugzilla/CGI.pm Committed revision 7827.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.