The default bug view has changed. See this FAQ.

#error "The cacheFlush support is missing on this platform." on mips, s390 and ia64

RESOLVED FIXED in mozilla6

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla6
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Previously, one didn't need to --disable something to successfully build on exotic architectures. This particular failure seems to be related to

ifeq (,$(filter-out powerpc sparc,$(TARGET_CPU)))
here -> http://mxr.mozilla.org/mozilla-central/source/js/src/Makefile.in#378

It looks like the logic is reversed here, and that it should use a filter instead. It also looks like this should be enclosed in a ifdef ENABLE_something.
(Assignee)

Comment 1

6 years ago
Created attachment 520157 [details] [diff] [review]
Avoid "The cacheFlush support is missing on this platform" error on exotic platforms

I tested this on s390, and this allows to build a working engine. I will test other architectures soon.
Assignee: nobody → mh+mozilla
(In reply to comment #1)
> Created attachment 520157 [details] [diff] [review]
> Avoid "The cacheFlush support is missing on this platform" error on exotic
> platforms
> 
> I tested this on s390, and this allows to build a working engine. I will test
> other architectures soon.

Yes please, tested working fine on OpenBSD/amd64 (which correctly enters in assembler/) and OpenBSD/sparc64 (which doesnt gets there). OpenBSD/mips64el test on the way.

Previously, i was using 
+ifneq (,$(filter-out sparc64,$(TARGET_CPU)))
 CXXFLAGS += -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1
+else
+CXXFLAGS += -DUSE_SYSTEM_MALLOC=1
+endif

using --disable-tracejit --disable-methodjit on sparc64 was not enough.

but mike's patch looks ways saner. Maybe enclose it within ENABLE_JIT test ? anyone can test on i386/amd64 with --disable-tracejit ?

Btw, forcing -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1 at the end of Makefile.in regardless of the arch looks weird.

And i think https://bugzilla.mozilla.org/show_bug.cgi?id=620368 & https://bugzilla.mozilla.org/show_bug.cgi?id=630854 could be marked as dupes of this bug.
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> Btw, forcing -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1 at the end of Makefile.in
> regardless of the arch looks weird.

Yet, it apparently builds and works fine, provided the js engine actually works (cf. jsvalue problems on ia64 and sparc64).
(Assignee)

Updated

6 years ago
Duplicate of this bug: 630854
(Assignee)

Updated

6 years ago
Duplicate of this bug: 620368
Confirmed producing a working js binary on OpenBSD/mips64el. Well, at least it runs like on sparc64, independently of the jsvalue problems we're likely to meet on mips64 too.
(Assignee)

Updated

6 years ago
Attachment #520157 - Flags: review?(cdleary)
(Assignee)

Comment 7

6 years ago
(In reply to comment #2)
> using --disable-tracejit --disable-methodjit on sparc64 was not enough.
> 
> but mike's patch looks ways saner. Maybe enclose it within ENABLE_JIT test ?
> anyone can test on i386/amd64 with --disable-tracejit ?

I think --disable-something bugs should be separated.
Comment on attachment 520157 [details] [diff] [review]
Avoid "The cacheFlush support is missing on this platform" error on exotic platforms

Don't actually know the syntax, but the semantics look good! Feel free to r? someone who knows the syntax better if you're at all concerned about it.
Attachment #520157 - Flags: review?(cdleary) → review+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/mozilla-central/rev/59771590e920
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Depends on: 652628
Duplicate of this bug: 659888

Comment 11

6 years ago
With the patch firefox-4.0.1 builds for me
on FreeBSD ia64 9.0 -current.

However, it dumps core on startup.
Duplicate of this bug: 627668
You need to log in before you can comment on or make changes to this bug.