Closed
Bug 652628
Opened 13 years ago
Closed 13 years ago
Fix for 638056 breaks MeeGo armv7 build
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla6
People
(Reporter: lokesh.kumar.goel, Assigned: glandium)
References
Details
Attachments
(3 files, 3 obsolete files)
PACKAGE VERSION: mozilla-central 68416:59771590e920 ENVIRONMENT: MeeGo(rpmbuild) armv7el Looks like the patch for bug#638056 breaks the armel build for MeeGo. See the errors below: /usr/bin/python2.6 /home/abuild/rpmbuild/BUILD/mozilla-central/js/src/config/pythonpath.py -I../config /home/abuild/rpmbuild/BUILD/mozilla-central/js/src/config/expandlibs_exec.py --uselist -- c++ -o js -frtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -fmessage-length=0 -march=armv7-a -mtune=cortex-a8 -mlittle-endian -mfpu=vfpv3 -mfloat-abi=softfp -D__SOFTFP__ -fno-strict-aliasing -pthread -march=armv5te -mthumb-interwork -msoft-float -pipe -DNDEBUG -DTRIMMED -g -g -O2 -fno-tree-ter -fno-ipa-reference -fno-tree-switch-conversion js.o jsworkers.o -lpthread -Wl,--no-keep-memory,-rpath-link,/home/abuild/rpmbuild/BUILD/release/dist/bin/:/usr/lib:/lib -Wl,-rpath-link,/bin -Wl,-rpath-link,/home/abuild/rpmbuild/BUILD/release/dist/lib -L../../../dist/bin -L../../../dist/lib -L/usr/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl ../editline/libeditline.a ../libjs_static.a -ldl ../libjs_static.a(jsapi.o): In function `~ExecutablePool': /home/abuild/rpmbuild/BUILD/mozilla-central/js/src/assembler/jit/ExecutableAllocator.h:128: undefined reference to `JSC::ExecutablePool::systemRelease(JSC::ExecutablePool::Allocation const&)' Also find attached the full rawlog of the build and the mozconfig used.
Reporter | ||
Comment 1•13 years ago
|
||
Reporter | ||
Comment 2•13 years ago
|
||
Reversing 68416:59771590e920 fixes the issue.
Reporter | ||
Updated•13 years ago
|
Severity: normal → major
Blocks: 638056
Assignee | ||
Comment 3•13 years ago
|
||
What is TARGET_CPU on meego ? armel ?
Reporter | ||
Comment 4•13 years ago
|
||
(In reply to comment #3) > What is TARGET_CPU on meego ? armel ? YES
Assignee | ||
Comment 5•13 years ago
|
||
Assignee: nobody → mh+mozilla
Assignee | ||
Updated•13 years ago
|
Attachment #528272 -
Flags: review?(cdleary)
Reporter | ||
Comment 6•13 years ago
|
||
(In reply to comment #5) > Created attachment 528272 [details] [diff] [review] > Add armel in the opt-in for the nitro assembler I am sorry, but this fix doesn't solve the problem. I tried this and it doesn't fix the issue. We build for two arm architectures in MeeGo armv7el(softfp) and armv8el(hardfp), the TARGET_CPU for MeeGo armv7el target seems to be "armv7l".
Reporter | ||
Comment 7•13 years ago
|
||
"armv7l" is the TARGET_CPU for both armv7el and armv8el. armv8el is actually armv7el + hardfp.
Reporter | ||
Comment 8•13 years ago
|
||
Reporter | ||
Comment 9•13 years ago
|
||
Assignee | ||
Comment 10•13 years ago
|
||
Even better
Attachment #528272 -
Attachment is obsolete: true
Attachment #528429 -
Attachment is obsolete: true
Attachment #528435 -
Attachment is obsolete: true
Attachment #528272 -
Flags: review?(cdleary)
Attachment #528437 -
Flags: review?(cdleary)
Updated•13 years ago
|
Attachment #528437 -
Flags: review?(cdleary) → review+
Assignee | ||
Comment 11•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c833fb1623ca
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•