638307 - Issues with Preliminary review queue in zamboni

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
Compare https://addons-next.allizom.org/en-US/editors/queue/preliminary to https://addons-next.allizom.org/z/en-US/editors/queue/preliminary


expected behavior:
lite review queue looks similar in remora and zamboni


observed behavior:
* zamboni has 612 add-ons in this queue as opposed 89 in remora
* longest waiting time in zamboni is 2113 days which seems suspect

Comment 1

[Kumar McMillan [:kumar]]

This looks to me like fallout from bug 630063.  That bug fixed the production code so that files for old versions are automatically disabled.  

The discrepancy in these queues seems to be for addons that were crated before that bug was fixed.  Do we need to run a migration script?  It should not be an issue for new addons.

For example the top 10 results match up:
https://addons.allizom.org/en-US/editors/queue/preliminary?sort=age&dir=desc
https://addons.allizom.org/z/en-US/editors/queue/preliminary?text_query=&admin_review=&application_id=&max_version=&waiting_time_days=9&sort=waiting_time_min

Specifically, there was a complicated left join on the versions table in Remora code that filtered out already-reviewed versions.  This join is no longer necessary after bug 630063

Comment 2

[Kumar McMillan [:kumar]]

Yeah, we do need a data migration otherwise these old versions will stick aroudn forever.  I'll prepare the migration SQL...

Comment 3

[Kumar McMillan [:kumar]]

Fixed in https://github.com/jbalogh/zamboni/commit/eacfec63ca3ee505216e8e6c0196b36e509e6ef0

Comment 4

[krupa raj[:krupa]]

remora has 106 add-ons @ https://addons-next.allizom.org/en-US/editors/queue/preliminary

zamboni has 100 add-ons @ https://addons-next.allizom.org/z/en-US/editors/queue/preliminary

what happened to the 6 missing add-ons?

Comment 5

[Kumar McMillan [:kumar]]

This is due to a bug in Remora.  It was causing duplicates and I fixed it in Zamboni.  Compare these two:

https://addons-next.allizom.org/z/en-US/editors/queue/preliminary?text_query=bug+6211534&admin_review=&application_id=&max_version=&waiting_time_days=

https://addons-next.allizom.org/en-US/editors/queue/preliminary
Search for this addon: bug 6211534

That's the same addon, same version so it shouldn't be listed twice.  Technically the version has two files which is what triggered the bug in remora.

Comment 6

[krupa raj[:krupa]]

Thanks, kumar!

Marking this as verified.