Closed
Bug 638429
Opened 13 years ago
Closed 13 years ago
Disallow --disable-libxul
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Mitch, Assigned: Mitch)
References
Details
(Whiteboard: fixed-in-bs)
Attachments
(1 file)
|
3.09 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This concerns only allowing --enable-libxul, and not allowing --disable-libxul for building.
FWIW I think we should error on disable libxul rather than silently ignoring it.
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #516582 -
Flags: review?(ted.mielczarek)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 516582 [details] [diff] [review] Patch +MOZ_ARG_DISABLE_BOOL(libxul, +[ --disable-libxul Disable building libxul (deprecated)], Maybe change this to (not supported) since it will actually raise an error?
Attachment #516582 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
http://hg.mozilla.org/projects/build-system/rev/d5ac43a73050
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/d5ac43a73050
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•