Closed
Bug 638643
Opened 12 years ago
Closed 11 years ago
Remove obsolete EditorToggleParagraphMarks from editor.js
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.13
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file, 2 obsolete files)
4.74 KB,
patch
|
neil
:
review+
iannbugzilla
:
feedback+
|
Details | Diff | Splinter Review |
Back in 2000 (https://bugzilla.mozilla.org/show_bug.cgi?id=22181#c20) the caller for this code was removed, so we should remove this code too. The entities were removed in 2008.
Attachment #516752 -
Flags: review?(neil)
Updated•12 years ago
|
Component: Editor → Composer
Product: Core → SeaMonkey
QA Contact: editor → composer
Comment 1•12 years ago
|
||
Comment on attachment 516752 [details] [diff] [review] Remove obsolete EditorToggleParagraphMarks code v1.0 >-const kParagraphMarksStyleSheet = "chrome://editor/content/EditorParagraphMarks.css"; I guess we should remove the file itself too no?
Attachment #516752 -
Flags: feedback?(kaze)
Attachment #516752 -
Flags: review?(neil)
Attachment #516752 -
Flags: feedback?(kaze)
Changes since v1.0: * Removed file EditorParagraphMarks.css too.
Attachment #516752 -
Attachment is obsolete: true
Attachment #516931 -
Flags: review?(neil)
Attachment #516931 -
Flags: feedback?(kaze)
Comment 4•11 years ago
|
||
Comment on attachment 642541 [details] [diff] [review] Rebased against current trunk [Checked in: Comment 7] Kaze tells me that it's OK to remove this. >diff -r f71ece130895 editor/ui/composer/content/EditorParagraphMarks.css >--- a/editor/ui/composer/content/EditorParagraphMarks.css Mon Jul 16 10:52:00 2012 +0200 >+++ /dev/null Nit: should have used hg diff --git
Attachment #642541 -
Flags: review?(neil) → review+
Updated•11 years ago
|
Attachment #516931 -
Flags: review?(neil)
Attachment #516931 -
Flags: review+
Attachment #516931 -
Flags: feedback?(kaze)
Attachment #516931 -
Flags: feedback+
(In reply to neil@parkwaycc.co.uk from comment #4) > Nit: should have used hg diff --git Just followed MDN advices, will use next time :)
Keywords: checkin-needed
Comment on attachment 642541 [details] [diff] [review] Rebased against current trunk [Checked in: Comment 7] http://hg.mozilla.org/comm-central/rev/0cca2a35dc4c
Attachment #642541 -
Attachment description: Rebased against current trunk → Rebased against current trunk [Checked in: Comment 7]
Attachment #642541 -
Flags: feedback+
Attachment #516931 -
Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.13
You need to log in
before you can comment on or make changes to this bug.
Description
•