638958 - [autoconfig] Smaller dialog height

Status: RESOLVED WORKSFORME

(Thunderbird :: Account Manager, defect)

Description

[Ben Bucksch (:BenB)]

Bug 549045 puts the Account Creation Wizard at a fixed size, to avoid constant resizing and jumping.

(The only time it does change the size is when going to and from manual edit mode, because it considerably increases the size (horizontally) and many users don't ever need it.)

Disadvantage fixed size:
- At start, and while finding the config (the majority of the time that
  the dialog is open), the dialog is too big, and looks funny.

Disadvantage size adjusting:
- We'd adjust size whenever we change modes, which is
  - between start and finding config
  - between finding config and displaying the result
  - (between displaying the result and going to manual config)
  - when going back a step
  - repeat
- This means, the Continue button is also changing position
- Even worse, on Linux at least, the dialog also changes position,
  not only change the size. With *every* resizing, it jumps down by
  10 px or so. This may be because it's centered to the mouse pointer,
  and the mouse pointer is at the bottom of the dialog on the
  Continue button.) This makes for a very funny effect.

The patch is trivial, and I made test builds, but before deciding, please test with Linux (Ubuntu 10.04 GNOME, with GNOME window manager, in my case) at least, preferably all platforms.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Fix, v1

Comment 2

[Ben Bucksch (:BenB)]

Test builds will appear at <http://ftp.mozilla.org/pub/mozilla.org/thunderbird/tryserver-builds/[e-mail]-82749b7823a9> (includes patch for bug 549045).

Comment 3

[Ben Bucksch (:BenB)]

bwinton said in bug 549045 comment 209, almost at the end of the comment, that:
Mac does *not* reposition the dialog after resize(), and a reposition would be *wanted* there. Odd. I think that's a platform-specific bug, though, which we'll be hard-pressed to fix.

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Ben Bucksch (:BenB) from comment #3)
> bwinton said in bug 549045 comment 209, almost at the end of the comment,
> that:
> Mac does *not* reposition the dialog after resize(), and a reposition would
> be *wanted* there. Odd. I think that's a platform-specific bug, though,
> which we'll be hard-pressed to fix.

paenglab, do you also think it is difficult?

Comment 5

[Richard Marti (:Paenglab)]

From the screenshots from bug 549045 comment 209 it seems at this time the dialog was a sheet. But now it's in his own window, so this is no more a issue.

Comment 6

[Wayne Mery (:wsmwk)]

thanks