Last Comment Bug 639716 - Move structToolbar xul code from editorOverlay
: Move structToolbar xul code from editorOverlay
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Composer (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Ian Neal
:
Mentors:
Depends on: 657214
Blocks: editorOverlaytidy
  Show dependency treegraph
 
Reported: 2011-03-07 18:23 PST by Ian Neal
Modified: 2011-06-19 11:36 PDT (History)
1 user (show)
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Move structToolbar xul code to editor patch v1.0 [Checked in: Comment 3] (6.04 KB, patch)
2011-03-12 13:10 PST, Ian Neal
neil: review+
standard8: review+
Details | Diff | Splinter Review

Description Ian Neal 2011-03-07 18:23:02 PST
structToolbar only appears to be used from editor.xul so there is some code that should be moved from editorOverlay file(s) and unused code removed from TB's forked editorOverlay.xul and theme files.
Comment 1 Ian Neal 2011-03-12 13:10:20 PST
Created attachment 518967 [details] [diff] [review]
Move structToolbar xul code to editor patch v1.0 [Checked in: Comment 3]

This patch:
* Moves code from SM's editorOverlay to editor.
* Removes the equivalent code from TB's editorOverlay.
* Removes the css entries from TB's theme files.
Comment 2 neil@parkwaycc.co.uk 2011-03-12 16:30:11 PST
Comment on attachment 518967 [details] [diff] [review]
Move structToolbar xul code to editor patch v1.0 [Checked in: Comment 3]

>-.struct-textbox {
>-  -moz-appearance: none !important;
>-  padding: 0px !important;
>-  margin: 0px !important;
>-  border: none !important;
>-}
[I wonder why this didn't use class="plain"]
Comment 3 Ian Neal 2011-03-16 08:53:29 PDT
Comment on attachment 518967 [details] [diff] [review]
Move structToolbar xul code to editor patch v1.0 [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/ef50f461a021

Note You need to log in before you can comment on or make changes to this bug.