Closed Bug 639794 Opened 9 years ago Closed 8 years ago

Opening a webpage from an external app should hide sidebars and panels

Categories

(Firefox for Android Graveyard :: General, defect, P3)

ARM
Android
defect

Tracking

(firefox8 fixed, fennec8+)

VERIFIED FIXED
Firefox 8
Tracking Status
firefox8 --- fixed
fennec 8+ ---

People

(Reporter: ioana.chiorean, Assigned: mfinkle)

Details

(Whiteboard: [regression])

Attachments

(2 files)

Build id : Mozilla/5.0 (Maemo;Linux armv7l;rv:2.0b13pre)Gecko/20110308
Firefox/4.0b13pre Fennec /4.0b6pre
Device: Samsung Galaxy S Captivate
OS: Android 2.1 update 1

Precondition: Fennec is selected as the default browser 

Steps to reproduce:
1. go to the right panel
2. quit fennec by tapping the home button
3. click on a web link on any app of the system

Actual result:
- Fennec show up but with the right panel into view

Expected result: 
- Fennec show up and the main view with the opened url is displayed

Note: 
- bug 632346 is Verified Fixed
Summary: Opening a new tab should hide the right panel → Opening a webpage from an external app should hide sidebars and panels
Ioana, can you post a screenshot?
Priority: -- → P3
Attached image screenshot
added screenshot.
This issue is still reproducing on:
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:2.2a1pre)Gecko/20110323
Firefox/4.0b13pre Fennec /4.1a1pre
Device: Sony Ericsson Xperia X10
OS: Android 2.1 update 1
This is a regression for bug 632346 https://bugzilla.mozilla.org/show_bug.cgi?id=632346. 

It's still reproduces on both builds:

Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110511 Firefox/6.0a1 Fennec/6.0a1

Mozilla /5.0 (Android;Linux armv7l;rv:5.0a2) Gecko/20110511 Firefox/5.0a2 Fennec/5.0a2
Whiteboard: [regression]
Also the TC in litmus: https://litmus.mozilla.org/show_test.cgi?id=13821 fails due to this bug 

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110519 Firefox/6.0a1 Fennec/6.0a1
tracking-fennec: --- → ?
Wes, can we just move the BrowserUI.hidePanel() calls to here:
http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/browser.js#1660
Assignee: nobody → wjohnston
tracking-fennec: ? → 8+
Attached patch patchSplinter Review
This patch ensures that sidebars, tool panels and autocomplete panels are hidden when opening a new tab (or loading into an existing tab). We try to do the same thing in other places where we start loading content into a new or existing tab.
Assignee: wjohnston → mark.finkle
Attachment #552900 - Flags: review?(mbrubeck)
Attachment #552900 - Flags: review?(mbrubeck) → review+
http://hg.mozilla.org/mozilla-central/rev/c974f3df9ace
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110815 Firefox/8.0a1 Fennec/8.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.