639799 - New icons for the tasks header

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: tasks header icons

Spinning off bug 470824
Here are some new icons for the tasks header

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: and the graphics

Really odd, the binary don't want to go into the patch. :/

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: new patch (do I get graphics?)

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: oops, wrong patch

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: with graphics in the patch

Comment 5

[Andreas Nilsson (:andreasn)]

The above patch depends on the patch in bug 641806

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 519523 [details] [diff] [review]
with graphics in the patch



>+    skin/calendar/tasks-actions.png						   (themes/@THEME@/images/tasks-actions.png)
>     skin/calendar/widgets/calendar-widgets.css             (themes/@THEME@/widgets/calendar-widgets.css)


Aside from that codewise r=philipp. Feel free to check in as soon as the dependent bug is fixed.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 519523 [details] [diff] [review]
with graphics in the patch

nice!  simple and clean, I like your check mark

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/1d7afda228c8

Comment 9

[Philip Chee]

What about winstripe??

processing c:/t1/hg/comm-20/calendar/base/jar.mn
Traceback (most recent call last):
  File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 507, in <module>
    main()
  File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 504, in main
    localedirs=options.l10n_src)
  File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 295, in makeJars
    jardir=jardir)
  File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 240, in makeJar
    localedirs)
  File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 361, in processJarSection
    outHelper, jf)
  File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 393, in _processEntryLine
    raise RuntimeError('File "%s" not found in %s' % (src, ', '.join(src_base)))
RuntimeError: File "themes/winstripe/images/tasks-actions.png" not found in c:\t1\hg\comm-20\calendar\base, .

Comment 10

[Philip Chee]

How about putting tasks-actions.png in themes/common/images/ ?

Comment 11

[Mark Banner (:standard8)]

Backed out due to build bustage: http://hg.mozilla.org/comm-central/rev/c69016cf520e

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Combined Patch

This patch combines the aero icons and normal icons. I have yet to test this under windows, so not checking in yet. Not requesting review since its basically just a slight modification to the previous patch (and I want this in).

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Combined Patch - v2

This one actually works on windows 7. Maybe someone can test this on windows xp. Otherwise I'll likely push this soon, or look for a machine to test by myself.

Comment 15

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 536242 [details] [diff] [review]
Combined Patch - v2

Review of attachment 536242 [details] [diff] [review]:
-----------------------------------------------------------------

Tested also on windows xp, works fine. The only issue I noticed on windows is that the disabled state is not always correct and there are lines above and below the toolbar, but thats a different issue. r=philipp

Comment 16

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Combined Patch - v3

This patch is much better, it uses the "style" chrome registration to register the css files. This means not every rule needs to be !important and we don't need the dummy namespace.

I have tested this on windows 7, linux and macosx.

Comment 17

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/48cf0f78c33b>
-> FIXED

Comment 18

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/fe022889d402>

Comment 19

[Stefan Sitter [:ssitter]]

Attachment: error on the priority button icon

There is an error either in the image map or the used css rule. The priority button icon (exclamation mark) shows pixel of the previous icon (checkmark) on the left side, see screenshot.

Mozilla/5.0 (Windows NT 6.1; rv:5.0) Gecko/20110605 Thunderbird/5.0b2pre

Comment 20

[Philipp Kewisch [:Fallen][📱📆]]

Will be fixed by bug 662142.