Closed
Bug 639865
Opened 14 years ago
Closed 12 years ago
Unchecked return value in ContentParent::OnAccelerationChange
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 621453
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning][needs review])
Attachments
(1 file)
|
1.39 KB,
patch
|
blassey
:
review-
|
Details | Diff | Splinter Review |
No description provided.
Attachment #517764 -
Flags: review?(blassey.bugs)
Flags: in-testsuite-
|
||
Comment 1•14 years ago
|
||
Comment on attachment 517764 [details] [diff] [review]
Patch v1
don't change the mode line or the white space. the functional part of this patch is fine though
Attachment #517764 -
Flags: review?(blassey.bugs) → review-
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 517764 [details] [diff] [review]
Patch v1
I disagree. The function right above this one already uses the correct indentation, so there's no reason not to fix it in passing. This file should never have used 4-space indentation.
Attachment #517764 -
Flags: review- → review?(blassey.bugs)
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 517764 [details] [diff] [review]
Patch v1
the function above has incorrect spacing. The rest of the file is 4 space indented as well as the majority of the directory.
Attachment #517764 -
Flags: review?(blassey.bugs) → review-
|
||
Updated•14 years ago
|
Blocks: buildwarning
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•