63992 - in account manager server panel, disable "Automatically..." if "Check..." is unchecked

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Håkan Waara]

Steps to see:

1. Open up Account Settings from Mail client
2. Select a mail account
3. Select the row "Server" under the mail account

The "Automatically download any new messages" is a sub-checkbox of "Check for
new messages every x minutes" checkbox. That's because the former is useless
without the latter checked.

Therefore I suggest we disable "Automatically..." if "Check..." is unchecked.
Because it's anyways useless to check.

Comment 1

[Håkan Waara]

Accepting.

Comment 2

[(not reading, please use [e-mail] instead)]

fixing summary, adding relevant people to the cc list.

Comment 3

[Håkan Waara]

Attachment: This patch is not done. It doesn't check when dialog "starts up" whether the checkbox is checked or not. I would appreciate if someone told me how to do that. But otherwise it works fine.

Comment 4

[timeless]

most objects get onload events, there should be an example near the mouse wheel 
prefs.

Comment 5

[(not reading, please use [e-mail] instead)]

this patch is not good yet.  hwaara and I discussed this over irc.

the plan is to move that function into am-server.js and then if it needs to be
called on startup, add a call to it in onInit() [in am-server.js]

Comment 6

[(not reading, please use [e-mail] instead)]

*** Bug 64187 has been marked as a duplicate of this bug. ***

Comment 7

[(not reading, please use [e-mail] instead)]

hwaara sent me a patch, and it worked fine.  I've made a few changes, including
disabling the "minutes" text field if the "biff" checkbox is unchecked.

I'll attach the patch.

racham, can you review it?

cc bienvenu for sr=

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: fix, please review.

Comment 9

[David :Bienvenu]

sr=bienvenu

Comment 10

[(not reading, please use [e-mail] instead)]

fix checked in.  thanks to hwaara for the original patch.

Comment 11

[(not reading, please use [e-mail] instead)]

re-opening until I fix this problem.

the first server in the account manager you select, this code doesn't get called.

I'll fix that before I mark this fixed again.

Comment 12

[(not reading, please use [e-mail] instead)]

finally fixed the right way.  sorry for the spam.

Comment 13

[(not reading, please use [e-mail] instead)]

reopening.  hwaara found a problem.

but I've got a fix.  this is the last time, I promise.

Comment 14

[(not reading, please use [e-mail] instead)]

taking from hwaara.  this bug should make me look bad, not him.

Comment 15

[(not reading, please use [e-mail] instead)]

fixed, again.

a very ungraceful bug fix.  shame on me.

Comment 16

[(not reading, please use [e-mail] instead)]

when #64225 gets fixed, I'll need to fix this again.

Comment 17

[(not reading, please use [e-mail] instead)]

now that #64224 is fixed I've fixed my JS and XUL.

much better now.

Comment 18

[Håkan Waara]

VERIFIED FIXED.

Comment 19

[Ninoschka Baca]

Also verified fixed on all three platforms (NT4, Linux 6.2, Mac 9.04)

Comment 20

[scottputterman]

*** Bug 41977 has been marked as a duplicate of this bug. ***