639928 - XUL persistence should ignore fragments in the page URL

Status: NEW

(Core :: XUL, defect)

Description

[Dave Townsend [:mossop]]

Currently persistence considers urls like chrome://global/content#foo and chrome://hlobal/content#bar as different and so persists different data. It should consider them as the same.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Fairly straightforward stuff. We just want to consider only the part of the URL before the first # for persistence purposes so everything after gets stripped off whenever persisting values or retrieving persisted values. The test case cycles through cases for chrome: and about: to verify that persistence works.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 518587 [details] [diff] [review]
patch rev 1

Why not use existing url functionality for this instead of reinventing the parsing wheel?

And note that if mDocumentURI is a jar: URI this code is just wrong.  Consider:

  jar:file:///home/me/foo.jar#bar!/baz.html#woops

Comment 3

[Dave Townsend [:mossop]]

I don't have the time for this anymore

Comment 4

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.