64022 - Mac Classic - menulist popup does not take the focus in prefs dialog

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[John Morrison]

Overview Description: 
  menulist popup does not take the focus in prefs dialog

Steps to reproduces:

1) Switch to the Classic skin (this does occur in Modern) 

2) get the 'Edit->Preferences->Fonts' panel (or alternatively you can
   use any pref panel that has a menulist

3) get the menulist popup for "Language Encoding" (or any other menulist).

4) hover the mouse over one of the menuitems

5) hit the up or down arrow

Actual results  : the keypress is delivered to the prefs tree on the left hand 
   side, resulting in a new panel being switched in. However, the popup for 
   'Language Encoding' remains popped-up over the new panel.

Expected results: like modern and classic and windows and linux, and modern on 
   mac, this keypress of the up or down arrow should move up or down the 
   menulist.

6) Now, click somewhere, not over the menulist popup, in an attempt to dismiss 
   the popup


Actual results  : crash
Expected results: should dismiss the popup

Reproducibility: 100% Classic skin on Mac

Build Date & Platform Bug Found: 2000122909

Comment 1

[John Morrison]

See also bug 43728, which introduced the ability to keyboard navigate in a 
menulist. (This does work correctly in Classic skin for e.g., the font style 
menulist in Composer, but does not work correctly in the prefs dialog).

Comment 2

[Blake Ross]

Beat you to it :-)

*** This bug has been marked as a duplicate of 63452 ***

Comment 3

[John Morrison]

Hm. Oh yeah, that bug. The one that I had already seen.

Comment 4

[Blake Ross]

reopening this since 63452 was fixed, but not for the menu aspect of it.  
shouldn't this be pink's?

Comment 5

[John Morrison]

This is specific to the Mac Classic skin, so not pinkerton's.

http://lxr.mozilla.org/seamonkey/source/themes/classic/global/mac/menulist.css
at line 12, sets '-moz-user-focus: ignore;' for element menulist. Is there a 
particular reason that that was set that way?

Comment 6

[timeless]

1.3 <[e-mail]> 17 Jul 2000 16:00 
Bug #43658. Classic skin changes to addressbook, buttons (to make look Mac-like
 ), colors, navigation toolbar buttons (to produce better mouse-over behavior), 
and small changes to spacing in
 radio buttons, menus, and checkboxes. r=hangas

lordpixel: could you try removing the relevant line and testing this for us?

Comment 7

[John Morrison]

The crash can be dealt with as bug 63452 (which is now re-re-opened). This bug
can just deal with why the menulist in Mac Classic is set to ignore focus.

Comment 8

[Andrew Thompson]

Yes, it crashes, yes removing that line "solves" the problem and causes the 
menulist to be keyboard navigable - i.e. up/down keys move the selection up and 
down.

The reason that line's there though, is because menulists on Mac OS don't allow 
keyboard navigation. When you press up or down, they simply close. 

I'd say someone needs to check Aqua, if it allows keyboard navigation, I'd feel 
its more acceptable to enable it.

Comment 9

[timeless]

My grapevine says keyboard nav will happen by final, cc for shorter vine 
confirmation.

Comment 10

[Mike Pinkerton (not reading bugmail)]

it's set to ignore focus because macos controls don't take focus, and this is
the mac native skin. what's so odd about that?

Comment 11

[John Morrison]

> what's so odd about that?

Nothing. Just my OS bigotry :-]. (And also the side effect of a popup that gets 
completely disconnected from its parent, and ultimately crashes).

Comment 12

[John Morrison]

Hrm, well andreww changed the focus for <menulist> with the new 9-slice button
in themes/classic/global/mac/menulist.css rev1.7. So, now it will take focus
(and it's not possible to set yourself up for the crash either). 

This should be worksforme, unless people feel that the menulist for mac
classic should ignore focus.

(By the way, Blake, is this a test case for the 'deeper menu problem' on 63452)

Comment 13

[Mike Pinkerton (not reading bugmail)]

the menulist for mac classic should ignore focus. all controls do except text 
areas.

Comment 14

[hangas]

Sending to Andrew

Comment 15

[andreww]

This is confusing. You sent me this bug because it's 'fixed' and you want me to 
'break' it again?  ok..

Comment 16

[german]

yes, why again is it a problem if we make this stuff more accessible? Many more
products on the MacOS platform are starting to implement this and even in
Cupertino Apple is thinking out loud on how to better comply with common
accessibility guidelines.
I do not think that for all practical terms and purposes this would get in the
way of Mac users without keyboard access needs. CC'ing aaronl, as he is the
resident accessibility expert...

Comment 17

[andreww]

Marking this current bug fixed - as the current behavior is consistent with this 
bug being fixed.  If there is an issue with this new behavior - file a new bug 
about that behavior. 

Comment 18

[Patty Mac]

Marking verified on Mac laptop G3 (2001-03-23-10-Mtrunk).