640376 - Add user feedback UI for all async actions

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Daniel Buchner [:dbuc]]

We should be throwing small spinners on the actual elements that are the source of async waiting periods instead of large masks.

This can be as easy as generating a few classes for the buttons and sidebar that will override the icons a given element contains or is associated with to show a small spinner instead.

Comment 1

[Piotr Zalewa [:zalun]]

I do believe spinner should cover the whole area which is affected by the action.

In example if someone would click on Add attachment while another attachment is creating, we would have problem with version numbers.

1. Version 3
2. Create attachment A
3. Create attachment B
4. A finished - version 4 is returned without attachment B
5. B finished - version 5 is finished without attachment A

4 and 5 may come back in other order

Comment 2

[Daniel Buchner [:dbuc]]

Whenever possible, please localize all UI feedback mechanisms on the elements that trigger them. If there is no element that triggers the action use your best judgement on where to show feedback to the user.

Elements/use-cases that need feedback UI:

- all Editor menu buttons that perform requests for content
- creation/upload of new files
- changing of SDK versions > spinner next to the 
- loading of tabs > the spinner should be on the tab itself, and only the tab that is selected should have a mask over the editor area. If I was to click on another previously loaded tab while one is loading, I should be able to interact with the editor and the loading tab will show a spinner on it alone.
- "Add a Library" autocompleter
- loading of images within the modal viewer in the editor

Comment 3

[Daniel Buchner [:dbuc]]

Attachment: mock for global FlightDeck editor spinner UI

If you want to go with a global spinner *in addition* to showing UI spinners on the elements that trigger the events, I think this is the route we should go.

It is in the same style as the new Firefox 6 download manager. Chowse and I discussed the UI implications and felt this was the best option.

Comment 4

[Sean McArthur [:seanmonstar]]

Broke tabs spinners into its own bug (658129), since it's a slightly different issue, and big enough to be it's own.

Comment 5

[Sean McArthur [:seanmonstar]]

landed in master https://github.com/mozilla/FlightDeck/commit/28ccf988e3c182ae400329a6cfeea37f188aba21