dropdown marker in urlbar is huge on Linux

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Location Bar
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Robert Kaiser, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
seamonkey2.1b3
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

6 years ago
In bug 401417, Neil and me both noticed that the urlbar and searchbar are vastly different in height on Linux due to an overly huge dropdown button in the urlbar. We might want to fix this in a way to make this one smaller.
(Assignee)

Comment 1

6 years ago
Created attachment 518500 [details] [diff] [review]
Proposed patch

We're actually using the toolkit CSS, which needs enablehistory="true" (rather than the old XPFE disablehistory="false") to display correctly on Linux. The first side-effect is that we can't give a custom border to the URLbar itself, although we never used it as -moz-appearance took priority. The second is that enablehistory="true" sets moz-appearance on the autocomplete-textbox-container  which makes it impossible to turn it yellow on a secure site, so I had to give the URLbar its own specific XBL content to achieve this.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #518500 - Flags: ui-review?(stefanh)
Attachment #518500 - Flags: review?(iann_bugzilla)
Attachment #518500 - Flags: feedback?(kairo)

Comment 2

6 years ago
Comment on attachment 518500 [details] [diff] [review]
Proposed patch

There's an issue when you've focused the url bar on a secure site. It looks like the bottom of the dropmarker obscures a small part of the focus ring.

Comment 3

6 years ago
Created attachment 518531 [details]
Screenshots

Screenshots, demonstrating the issue.
(Assignee)

Comment 4

6 years ago
What if you back out the Mac theme changes? I only changed them to be consistent with Linux.

Comment 5

6 years ago
(In reply to comment #4)
> What if you back out the Mac theme changes? I only changed them to be
> consistent with Linux.

Yeah, that looks better. I'll take a more detailed look tomorrow - I haven't looked at the other autocompletes.

Comment 6

6 years ago
(In reply to comment #1)
> The second is that
> enablehistory="true" sets moz-appearance on the autocomplete-textbox-container 
> which makes it impossible to turn it yellow on a secure site, so I had to give
> the URLbar its own specific XBL content to achieve this.

Wouldn't "-moz-appearance: none" be better than adding all the xbl content?
(Assignee)

Comment 7

6 years ago
(In reply to comment #6)
> (In reply to comment #1)
> > The second is that
> > enablehistory="true" sets moz-appearance on the autocomplete-textbox-container 
> > which makes it impossible to turn it yellow on a secure site, so I had to give
> > the URLbar its own specific XBL content to achieve this.
> Wouldn't "-moz-appearance: none" be better than adding all the xbl content?
No, because on a Linux enablehistory autocomplete it's what draws the border.

Comment 8

6 years ago
(In reply to comment #7)
> > Wouldn't "-moz-appearance: none" be better than adding all the xbl content?
> No, because on a Linux enablehistory autocomplete it's what draws the border.

Aha, OK.

Comment 9

6 years ago
Comment on attachment 518500 [details] [diff] [review]
Proposed patch

This is fine on Mac default if you revert the mac/navigator/navigator.css changes.
Attachment #518500 - Flags: ui-review?(stefanh) → ui-review+
(Assignee)

Comment 10

6 years ago
Created attachment 518780 [details] [diff] [review]
Potential alternate mac styling

The previous patch went wrong because it applied the colour to an element contained inside a padded element. This should fix that by moving the padding.

This just replaces the hunk for mac's navigator.css from attachment 518500 [details] [diff] [review].
Attachment #518780 - Flags: review?(stefanh)

Comment 11

6 years ago
Comment on attachment 518780 [details] [diff] [review]
Potential alternate mac styling

Sorry, this won't work - it creates a white line under the dropmarker. See the screnshot in the next comment.

Comment 12

6 years ago
Created attachment 518848 [details]
Screenshot

Comment 13

6 years ago
Created attachment 518852 [details]
Screenshot - when focused
(Assignee)

Comment 14

6 years ago
(In reply to comment #11)
> Sorry, this won't work - it creates a white line under the dropmarker. See the
> screnshot in the next comment.
Bah, why does the Mac have to be so weird :-( I give up.

Comment 15

6 years ago
Comment on attachment 518500 [details] [diff] [review]
Proposed patch

r=me with linux css changes only
Attachment #518500 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 16

6 years ago
Pushed changeset 64392a2ec60c to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(In reply to comment #16)
> Pushed changeset 64392a2ec60c to comm-central.

FTR: You botched the bug number; maybe add a note to bug 420421?

Updated

6 years ago
Target Milestone: --- → seamonkey2.1b3

Comment 18

6 years ago
Comment on attachment 518780 [details] [diff] [review]
Potential alternate mac styling

Clearing out obsolete request.
Attachment #518780 - Flags: review?(stefanh)
(Assignee)

Updated

6 years ago
Depends on: 642404
(Reporter)

Updated

6 years ago
Attachment #518500 - Flags: feedback?(kairo)

Updated

6 years ago
Blocks: 643404
You need to log in before you can comment on or make changes to this bug.