Closed Bug 640421 Opened 11 years ago Closed 11 years ago

dropdown marker in urlbar is huge on Linux

Categories

(SeaMonkey :: Location Bar, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b3

People

(Reporter: kairo, Assigned: neil)

References

Details

Attachments

(5 files)

In bug 401417, Neil and me both noticed that the urlbar and searchbar are vastly different in height on Linux due to an overly huge dropdown button in the urlbar. We might want to fix this in a way to make this one smaller.
Attached patch Proposed patchSplinter Review
We're actually using the toolkit CSS, which needs enablehistory="true" (rather than the old XPFE disablehistory="false") to display correctly on Linux. The first side-effect is that we can't give a custom border to the URLbar itself, although we never used it as -moz-appearance took priority. The second is that enablehistory="true" sets moz-appearance on the autocomplete-textbox-container  which makes it impossible to turn it yellow on a secure site, so I had to give the URLbar its own specific XBL content to achieve this.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #518500 - Flags: ui-review?(stefanh)
Attachment #518500 - Flags: review?(iann_bugzilla)
Attachment #518500 - Flags: feedback?(kairo)
Comment on attachment 518500 [details] [diff] [review]
Proposed patch

There's an issue when you've focused the url bar on a secure site. It looks like the bottom of the dropmarker obscures a small part of the focus ring.
Attached image Screenshots
Screenshots, demonstrating the issue.
What if you back out the Mac theme changes? I only changed them to be consistent with Linux.
(In reply to comment #4)
> What if you back out the Mac theme changes? I only changed them to be
> consistent with Linux.

Yeah, that looks better. I'll take a more detailed look tomorrow - I haven't looked at the other autocompletes.
(In reply to comment #1)
> The second is that
> enablehistory="true" sets moz-appearance on the autocomplete-textbox-container 
> which makes it impossible to turn it yellow on a secure site, so I had to give
> the URLbar its own specific XBL content to achieve this.

Wouldn't "-moz-appearance: none" be better than adding all the xbl content?
(In reply to comment #6)
> (In reply to comment #1)
> > The second is that
> > enablehistory="true" sets moz-appearance on the autocomplete-textbox-container 
> > which makes it impossible to turn it yellow on a secure site, so I had to give
> > the URLbar its own specific XBL content to achieve this.
> Wouldn't "-moz-appearance: none" be better than adding all the xbl content?
No, because on a Linux enablehistory autocomplete it's what draws the border.
(In reply to comment #7)
> > Wouldn't "-moz-appearance: none" be better than adding all the xbl content?
> No, because on a Linux enablehistory autocomplete it's what draws the border.

Aha, OK.
Comment on attachment 518500 [details] [diff] [review]
Proposed patch

This is fine on Mac default if you revert the mac/navigator/navigator.css changes.
Attachment #518500 - Flags: ui-review?(stefanh) → ui-review+
The previous patch went wrong because it applied the colour to an element contained inside a padded element. This should fix that by moving the padding.

This just replaces the hunk for mac's navigator.css from attachment 518500 [details] [diff] [review].
Attachment #518780 - Flags: review?(stefanh)
Comment on attachment 518780 [details] [diff] [review]
Potential alternate mac styling

Sorry, this won't work - it creates a white line under the dropmarker. See the screnshot in the next comment.
Attached image Screenshot
(In reply to comment #11)
> Sorry, this won't work - it creates a white line under the dropmarker. See the
> screnshot in the next comment.
Bah, why does the Mac have to be so weird :-( I give up.
Comment on attachment 518500 [details] [diff] [review]
Proposed patch

r=me with linux css changes only
Attachment #518500 - Flags: review?(iann_bugzilla) → review+
Pushed changeset 64392a2ec60c to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to comment #16)
> Pushed changeset 64392a2ec60c to comm-central.

FTR: You botched the bug number; maybe add a note to bug 420421?
Target Milestone: --- → seamonkey2.1b3
Comment on attachment 518780 [details] [diff] [review]
Potential alternate mac styling

Clearing out obsolete request.
Attachment #518780 - Flags: review?(stefanh)
Depends on: 642404
Attachment #518500 - Flags: feedback?(kairo)
Blocks: 643404
You need to log in before you can comment on or make changes to this bug.