640461 - Firefox 4 button on system requirements links to Firefox 3.6.15

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[raymond [:retornam] (inactive)]

Attachment: screenshot

STR:
1) Visit http://www.mozilla.com/en-US/firefox/system-requirements.html
2) Click the FIrefox4 download button
3) It links to Firefox 3.6.15

See attached screenshot... ( look at the link on the addon bar)

Comment 1

[James Long (:jlongster)]

This is a side effect of intentionally pointing that URL to the 4.0 requirements. It looks like the official URLs for system requirements have the version number (/firefox/3.6/sys-reqs.html), but that old URL by default goes to 4.0 version.

But since 4.0 hasn't been released yet, the download button links to 3.6.

That page is only linked to from somewhere deep in the release notes, and it's probably not worth figuring out how to fix since 4.0 is going to be released soon.

Comment 2

[LegNeato]

All the release notes page should have been updated with a relative link to system-requirements/, which gets them to the version expected via redirects (like http://www.mozilla.com/en-US/firefox/3.6.15/releasenotes/ and http://www.mozilla.com/en-US/firefox/3.5.17/releasenotes/).

Did you find a page that links directly to http://www.mozilla.com/en-US/firefox/system-requirements.html? If so it should be changed.

Comment 3

[James Long (:jlongster)]

http://www.mozilla.com/en-US/firefox/4.0rc1/releasenotes/

system requirements section links to that url

Comment 4

[James Long (:jlongster)]

http://www.mozilla.com/en-US/firefox/4.0/releasenotes/ has the same problem. 3.6 is downloaded from the button.

Comment 5

[James Long (:jlongster)]

Sorry, wrong url. this URL has the same problem:

http://www.mozilla.com/en-US/firefox/4.0/system-requirements/

Comment 6

[kitchin]

See also Bug 586314 Comment 72 the harblocker final+ which caused this bug.

Comment 7

[LegNeato]

So, yeah, this is a bigger problem we should fix...downloading FF3.6 from http://www.mozilla.com/en-US/firefox/4.0/system-requirements/ is not ideal in the slightest, though I bet the % that downloads from there is very small.

Comment 8

[LegNeato]

I put a stopgap in with rev84723. There is now an unstyled link that points to the RC rather than a mislabeled green button. We'll want to keep this open to fix it correctly with a pretty button.

Comment 9

[James Long (:jlongster)]

Thanks Christian -- you commented before I wrote this, but I'll post this anyway:

I don't know anything about the download button scripts. Here is the code on
the system requirements page:

<div id="download" class="top-right">
    <script src="/js/download.js"></script>
    <?php
        $_options = array('ancillary_links' => true, 'layout' => 'subpage',
'download_parent_override' => 'download', '_include_js' => true,
'download_product' => 'Firefox 4.0');
        echo $firefoxDetails->getNoScriptBlockForLocale('en-US', $_options);
        echo $firefoxDetails->getDownloadBlockForLocale('en-US', $_options);
    ?>
</div>

Why is it linking to 3.6 when the download product say "Firefox 4.0"?

Comment 10

[LegNeato]

I don't know anything about it either, but looks like I fixed it with http://viewvc.svn.mozilla.org/vc?view=revision&revision=84728 on trunk, yay!

Comment 11

[LegNeato]

Should be pushed live in r84730

Comment 12

[raymond [:retornam] (inactive)]

qa-verified-trunk http://www-trunk.stage.mozilla.com/en-US/firefox/4.0/system-requirements/index.html

Comment 13

[James Long (:jlongster)]

woot! great!

Comment 14

[raymond [:retornam] (inactive)]

verified fixed http://www.mozilla.com/en-US/firefox/4.0/system-requirements/index.html

Comment 15

[David Lawrence [:dkl]]

Restoring unintended removal of in-testsuite flag.