640524 - mozmill should dump more debugging info when update tests fail

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[[e-mail] (:bhearsum)]

When trying to debug bug 640361, which was a problem that only Mozmill could produce, it was very frustrating not to have all the necessary information dumped by it. Ideally, it would give us the following:
- Full AUS URL used
- Full contents of update snippet returned, and HTTP headers of the request
- Particulars (file size, hash) of the update package downloaded, and HTTP headers of the request.

Not sure how easy it is to get the headers, but they can be super helpful in debugging, so highly desired.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #0)
> - Full AUS URL used

This is bug 640369.

> - Full contents of update snippet returned, and HTTP headers of the request

Would it be enough to log all information for patches from the activeUpdate?

> - Particulars (file size, hash) of the update package downloaded, and HTTP
> headers of the request.

That's already done on bug 569477 and exposed in our dashboard.

See:
http://mozmill-archive.brasstacks.mozilla.com/#/update/report/28b01810d9c46945a70f83d6672f23c8

Not sure about the headers of the request. Which additional information would those give us?

Comment 2

[[e-mail] (:bhearsum)]

(In reply to comment #1)
> (In reply to comment #0)
> > - Full AUS URL used
> 
> This is bug 640369.
> 
> > - Full contents of update snippet returned, and HTTP headers of the request
> 
> Would it be enough to log all information for patches from the activeUpdate?

Can you give me an example of this? I don't know what activeUpdate is.

> > - Particulars (file size, hash) of the update package downloaded, and HTTP
> > headers of the request.
> Not sure about the headers of the request. Which additional information would
> those give us?

It would tell us if any HTTP server along the way is doing weird things, like redirecting requests for a partial to a complete. More generally, it helps in ruling things out.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> > Would it be enough to log all information for patches from the activeUpdate?
> 
> Can you give me an example of this? I don't know what activeUpdate is.

All the listed patches contain those information:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsIUpdateService.idl#54

> It would tell us if any HTTP server along the way is doing weird things, like
> redirecting requests for a partial to a complete. More generally, it helps in
> ruling things out.

That part I would definitely defer until we have finished the API refactoring of Mozmill tests.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to comment #3)
> (In reply to comment #2)
> > > Would it be enough to log all information for patches from the activeUpdate?
> > 
> > Can you give me an example of this? I don't know what activeUpdate is.
> 
> All the listed patches contain those information:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsIUpdateService.idl#54
> 

I would greatly prefer the raw snippet, to avoid being bitten by bugs in parsing it.


> > It would tell us if any HTTP server along the way is doing weird things, like
> > redirecting requests for a partial to a complete. More generally, it helps in
> > ruling things out.
> 
> That part I would definitely defer until we have finished the API refactoring
> of Mozmill tests.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I would like to wait for bug 605343 first and take this into account for refactoring our software update module.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Ben Hearsum (:bhearsum) from comment #0)

Mozmill tests are no longer in use. So I'm closing this bug. 

> - Full AUS URL used

We have that info for our firefox-ui-tests.

> - Full contents of update snippet returned, and HTTP headers of the request

Headers we have via the HTTP log uploaded beside the test results to Treeherder. For the full contents I filed bug 1261101.

> - Particulars (file size, hash) of the update package downloaded, and HTTP
> headers of the request.

That should be all visible in the log.