64079 - [MF][FIX][CBX]Drop-down listbox should disappear when it loses focus

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Load http://bugzilla.mozilla.org/query.cgi and scroll down to the "boolean 
chart" section.
2. Click on the leftmost drop-down menu.
3. Hit tab.

Result: drop-down sticks around, but focus moves to another control.
Expected result: drop-down goes away, and focus moves to another control.

Comment 1

[Tobias Burnus]

(This seems to be a "better" bug than mine, bug 62425)

Comment 2

[rods (gone)]

When it lose focus it needs to rollup the drop down.

Comment 3

[rods (gone)]

Attachment: simple patch

Comment 4

[Tobias Burnus]

If you use this patch, please also change the spelling of "// Thiis ..." one
line further down in the patch.

Comment 5

[rods (gone)]

Patch;
Index: nsComboboxControlFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/forms/src/nsComboboxControlFrame.cpp,v
retrieving revision 1.155
diff -u -r1.155 nsComboboxControlFrame.cpp
--- nsComboboxControlFrame.cpp	2000/12/20 23:25:39	1.155
+++ nsComboboxControlFrame.cpp	2001/01/02 16:28:47
@@ -496,7 +498,14 @@
 void 
 nsComboboxControlFrame::SetFocus(PRBool aOn, PRBool aRepaint)
 {
-  mFocused = aOn?this:nsnull;
+  if (aOn) {
+    mFocused = this;
+  } else {
+    mFocused = nsnull;
+    if (mDroppedDown) {
+      ToggleList(mPresContext);
+    }
+  }
   // Thiis is needed on a temporary basis. It causes the focus
   // rect to be drawn. This is much faster than ReResolvingStyle
   // Bug 32920

Comment 6

[Kevin McCluskey (gone)]

patch looks good.
r=[e-mail]

Comment 7

[Eric Pollmann]

Looks good to me too.  :)  r=[e-mail]

Comment 8

[rods (gone)]

fixed

Comment 9

[jerone]

Verfied build 20010730 os:win95/win98