640957 - Write tests for thumbnail generation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We keep running into problems where thumbnails are drawn at sizes bigger than the browser, causing corruption to show up. We need tests to make sure we don't regress this again.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Simple Tests

These tests just check that when the call to draw thumbnail's occurs, the widths and heights given are within the bounds of the current browser's contentDocument. Most of the test cases are just stolen from the viewport tests.

Upated patch in bug 640768 required in order for these to pass.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 519489 [details] [diff] [review]
Simple Tests

The resizeTo() code in secondPass will only work on desktop. Normally, if the entire tests depended on running on desktop, I'd recommend putting a preproc test in the makefil, like browser_sidebars.js, but in this case, some of the test will work on a device.

Maybe you could check SysInfo to see what the "device" is. If null, it's desktop and you can play with resizeTo.

You could also preproc the test file and "make" it work both ways.

Looks good but lets get a new patch that handles desktop vs device

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Updated to check for a device using sysInfo. If not null, it will only run the tests in the current orientation.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 521554 [details] [diff] [review]
Patch v2

We can sue this approach for now. If it causes trouble, we can switch to a processed approach.

Comment 5

[Wesley Johnston (:wesj)]

pushed: http://hg.mozilla.org/mobile-browser/rev/3597716f2b71