641141 - [backend] Implement personas review queue

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P1)

Description

[Wil Clouser [:clouserw]]

Mockup: http://people.mozilla.com/~chowse/drop/amo/personas/v1/Review_Queue.png
Demo: http://people.mozilla.com/~chowse/drop/amo/personas/review/

This bug is for the backend of the review queue.  input/output is fairly straightforward but there are three things that need to be taken into consideration:

1) the "forever scroll" effect (see the demo).  Reviewers should be able to continue advancing down the list until prompted with a message that there are no more personas to review.

2) We want to allow multiple reviewers to work simultaneously without reviewing the same personas.  We'll need some kind of locking when the persona is shown on the screen (and something to clear the lock if it never gets reviewed).

3) Just like with add-ons, approve/reject/duplicate/moreinfo all send emails to the authors.  

I'm CCing deb for email content and the title/content of the rejection drop down.

Note that in questions of differences between mockup and demo, the demo is correct.

Comment 1

[Wil Clouser [:clouserw]]

> 3) Just like with add-ons, approve/reject/duplicate/moreinfo all send emails to
> the authors.

On request of legal, add-ons flagged for legal should send email to the legal team also.  Just make a new constant in settings.py that will take a list of addresses.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to Wil Clouser [:clouserw] from comment #1)
> > 3) Just like with add-ons, approve/reject/duplicate/moreinfo all send emails to
> > the authors.
> 
> On request of legal, add-ons flagged for legal should send email to the
> legal team also.  Just make a new constant in settings.py that will take a
> list of addresses.

Disregard all of that.  There is nothing special for legal now.  The persona queue workflow should mirror that of the other queues - if there is a question about a persona it gets admin flagged just like add-ons.  The queue should show these with the same flags as add-ons.

Comment 3

[Wil Clouser [:clouserw]]

Please coordinate with Potch on the frontend.

Comment 4

[Wil Clouser [:clouserw]]

Currently in review.  Bumping to next week for QA alignment

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Landed by end of week.

Comment 6

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/921b9e8a23527768e076fb18b3b42962dc617c6d

at /reviewers/themes/queue

Comment 7

[Christopher Van Wiemeersch [:cvan]]

Behind `mkt-themes` waffle switch.