641247 - Remove unused commands, commandset, broadcaster and toolbarbuttons from editorOverlay

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Ian Neal]

Attachment: Remove unused elements for editorOverlay patch v1.0 [Checked in: Comment 3]

When editorOverlay.xul was forked there was xul code left in which was not used by message compose window, it should probably be removed.

This patch does that.

Comment 1

[Ian Neal]

The dependency on bug 641246 is only due to potential bit rot.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 518965 [details] [diff] [review]
Remove unused elements for editorOverlay patch v1.0 [Checked in: Comment 3]

This look goods, thanks.

One thing though: I think we should move the equivalent items (especially newButton etc) out of editor's version of editorOverlay.xul and into editor.xul

Then we can also move the relevant strings out of editorOverlay.dtd and into editor.dtd so that Thunderbird's localisers don't have to localise a whole load of strings they are never going to see.

I'm quite happy for this to land first and that to be a follow-up though.

Comment 3

[Ian Neal]

Comment on attachment 518965 [details] [diff] [review]
Remove unused elements for editorOverlay patch v1.0 [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/c14335098d9f

Yes, I had in mind to do the entities in another bug, but the editorOverlay.xul is shared by 3 files in SM so only some bits can be moved into editor.xul