Remove unused commands, commandset, broadcaster and toolbarbuttons from editorOverlay

RESOLVED FIXED in Thunderbird 5.0b1

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
Thunderbird 5.0b1
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 518965 [details] [diff] [review]
Remove unused elements for editorOverlay patch v1.0 [Checked in: Comment 3]

When editorOverlay.xul was forked there was xul code left in which was not used by message compose window, it should probably be removed.

This patch does that.
Attachment #518965 - Flags: review?(bugzilla)
(Assignee)

Updated

7 years ago
Depends on: 641246
No longer depends on: 64124
(Assignee)

Comment 1

7 years ago
The dependency on bug 641246 is only due to potential bit rot.
Comment on attachment 518965 [details] [diff] [review]
Remove unused elements for editorOverlay patch v1.0 [Checked in: Comment 3]

This look goods, thanks.

One thing though: I think we should move the equivalent items (especially newButton etc) out of editor's version of editorOverlay.xul and into editor.xul

Then we can also move the relevant strings out of editorOverlay.dtd and into editor.dtd so that Thunderbird's localisers don't have to localise a whole load of strings they are never going to see.

I'm quite happy for this to land first and that to be a follow-up though.
Attachment #518965 - Flags: review?(bugzilla) → review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 518965 [details] [diff] [review]
Remove unused elements for editorOverlay patch v1.0 [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/c14335098d9f

Yes, I had in mind to do the entities in another bug, but the editorOverlay.xul is shared by 3 files in SM so only some bits can be moved into editor.xul
Attachment #518965 - Attachment description: Remove unused elements for editorOverlay patch v1.0 → Remove unused elements for editorOverlay patch v1.0 [Checked in: Comment 3]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
You need to log in before you can comment on or make changes to this bug.