641250 - showdown-highlight page rendering funny

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Dave Herman [:dherman]]

Attachment: screen shot of funky rendering

This page:

    http://softwaremaniacs.org/playground/showdown-highlight/

is rendering funny on my MacBook Pro with hardware acceleration enabled, both in the nightly and RC. Attaching a screen shot. It self-corrects after a couple seconds or after some slight interaction like moving the mouse or clicking. Disabling hardware acceleration fixes it.

Don't know if it's relevant, but the web console spits out the warning about document.write() creating an unbalanced tree.

Dave

Comment 1

[Jonathan Kew [:jfkthame]]

The broken rendering appears to be connected with scrolling. (Note that when the page loads, it scrolls the left-hand (source) pane to the bottom.) If I hit Command-R to reload at that point, nothing untoward happens; but if I scroll the left-hand pane back to the top, and then hit Command-R, the rendering problem (where content of the right-hand pane is blitted to the left-hand one) happens again.

Comment 2

[Andreas Gal :gal]

scrolling sounds like layers

Comment 3

[Jonathan Kew [:jfkthame]]

Further observation: the problem only occurs on Reload if the left-hand pane is scrolled _ALL_ the way to the top; if I adjust its scroll position even just a couple of pixels from the top, and then Reload, it scrolls cleanly to the bottom with no rendering artifacts.

Comment 4

[Jonathan Kew [:jfkthame]]

Works: 2011-01-17 (66addc5c30ca)
Fails: 2011-01-18 (eb105fe0e41c)

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=66addc5c30ca&tochange=eb105fe0e41c

Comment 5

[Jonathan Kew [:jfkthame]]

Specifically, this is a regression from 31b46f48f714 (bug 621778).

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Upload the full surface if the texture contents are uninitialized

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Alternate fix

I think I like this one better, it makes the texture state clearer than having two bool vars.

Comment 8

[Matt Woodrow (:mattwoodrow)]

Attachment: Alternate fix v2

Actually qref the changes

Comment 9

[Joe Drew (not getting mail)]

Comment on attachment 520381 [details] [diff] [review]
Upload the full surface if the texture contents are uninitialized

agreed - the enumerated type is better.

Comment 10

[Joe Drew (not getting mail)]

Comment on attachment 520387 [details] [diff] [review]
Alternate fix v2

Would love to see a test.

Comment 11

[Matt Woodrow (:mattwoodrow)]

Landed the fix as: http://hg.mozilla.org/mozilla-central/rev/5cd1f196e421

Will try write a test for this today.

Comment 12

[Matt Woodrow (:mattwoodrow)]

Attachment: Rename Initialized to Allocated

Comment 13

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/c2242c63e75f